Use git describe for Bio-Formats version (See #9639)
#627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two calls are made to git-describe in order to detect whether this is an exact or an inexact match for a tag. The release.version property is then built up from the parsed tag and should be used as the basis for all versions.
Unclear why this exists!
Unclear why these were set to different values.
This was referenced Aug 7, 2013
Merged
|
All seems to work as expected with Ant. Do you want Maven commits added as a PR against |
|
Either way, @melissalinkert. |
|
Merging then, and I'll open a corresponding Maven PR hopefully later today. |
melissalinkert
added a commit
that referenced
this pull request
Aug 12, 2013
Use `git describe` for Bio-Formats version (See #9639)
5 tasks
|
--rebased-to #636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current releases 2 PRs in the BF repository: 1 to bump the version numbers to the release value (
4.5-DEV-->5.0.0-beta1) and one to bump to either rollback or to bump to new DEV versions (5.0.0-beta1-->4.5-DEVor5.0.0-beta2-DEV)Tasks/features involved:
ant/common.xmlbuild.propertiesfiles and sourceomero.version