Flake8 OmeroFS

[ximenesuk]

In order to make proposed changes to DropBox it makes sense to have OmeroFS flake8 compliant first. This PR does that. It also moves the fs files to a src directory and modifies the build to handle that.

Tests under OmeroFS should pass and DropBox on three representative platforms should work as normal.

--no-rebase

[sbesson]

Is it worth adding flake8 components/tools/OmeroFs/src to the Travis build-python pre-build step?

[sbesson]

For some (still mysterious) reason, this PR seems to be at the origin of the failing http://ci.openmicroscopy.org/job/OMERO-5.1-merge-build/ICE=3.4,jdk=7_LATEST,label=ome-c6100-3/ (no omero_version.py) - cf Travis logs. Excluding for today.

[ximenesuk]

@sbesson on the first question, once it is fit to merge, yes that was my hope. On the failing build, I saw this once when I tried to run a build locally. I then tried to track it down and couldn't reproduce so I put it down top a local problem. Clearly it isn't! I'll take a look today but any pointers welcome! I assume it has to be a problem with the first two commits. /cc @joshmoore

[ximenesuk]

Hmm, it looks like I have killed the copying of omero_version.py to dist/lib/python/ but I'm not sure how, presumably in ximenesuk@73d7728. There is an omero_version.py created in each of the Python tools directories so I'm not clear which one is copied up. I'll investigate!

[ximenesuk]

This final commit fixes the build so that omero_version.py is copied to the libs directly from OmeroPy. This seems the simplest short term solution with least impact.

[sbesson]

Travis log files are encouraging. Reincluding for Monday.

[sbesson]

Changeset looks good, the server is properly building and the unit tests are still passing. Proposed next steps for this PR:

• add flake8 to components/tools/travis-build
• fix componts/tools/OmeroFS/setup.py to be able to run the integration tests without pytest installed (my guess is that we just need https://github.com/openmicroscopy/openmicroscopy/blob/develop/components/tools/OmeroPy/setup.py#L62)
• reactivate the OmeroFS integration jobs and check everything is green

[ximenesuk]

@sbesson First two points addressed so that you can look at this before I get back. If the PR is good then I'll let you activate the integration jobs.

[sbesson]

Thanks @ximenesuk. Will test this locally and reactivate the integration tests.

[sbesson]

With sbesson@a79d311 on top of this branch, I am able to run locally

$ ./build.py -f components/tools/OmeroFS/build.xml integration

Want to cherry-pick/duplicate it on this PR before I extend the integration jobs?

[ximenesuk]

Done. Thanks for spotting this @sbesson

[sbesson]

Dropbox tests now added to the daily integration job. See https://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-integration-python/280/testReport/test.integration.test_dbclient/TestDropBoxClient/ for the current state. Thanks @ximenesuk. Merging.