New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-377:Add option to change session location from within the app #421

Merged
merged 1 commit into from May 26, 2018

Conversation

Projects
None yet
3 participants
@csmuthukuda
Contributor

csmuthukuda commented Mar 15, 2018

@shivtej1505 Sorry, I accidentally Closed the previous pull request #418
.Please review this one and sorry again for the trouble I have made.

@csmuthukuda

This comment has been minimized.

Show comment
Hide comment
@csmuthukuda

csmuthukuda Mar 15, 2018

Contributor

this is how the UI looks like..
screenshot_20180316-001158

Contributor

csmuthukuda commented Mar 15, 2018

this is how the UI looks like..
screenshot_20180316-001158

@shivtej1505

This comment has been minimized.

Show comment
Hide comment
@shivtej1505

shivtej1505 Mar 22, 2018

Member

29542289_1346947978738018_7506314407643709440_n

Great work @csmuthukuda!
It would be great if we can preselect the location already selected (for example, in the screenshot we can pre-select Pharmacy) and then there will be no need to show the toast.

Member

shivtej1505 commented Mar 22, 2018

29542289_1346947978738018_7506314407643709440_n

Great work @csmuthukuda!
It would be great if we can preselect the location already selected (for example, in the screenshot we can pre-select Pharmacy) and then there will be no need to show the toast.

@csmuthukuda

This comment has been minimized.

Show comment
Hide comment
@csmuthukuda

csmuthukuda Mar 24, 2018

Contributor

@shivtej1505 done.Please review it

Contributor

csmuthukuda commented Mar 24, 2018

@shivtej1505 done.Please review it

@openmrs openmrs deleted a comment from codacy-bot Mar 24, 2018

@openmrs openmrs deleted a comment from codacy-bot Mar 24, 2018

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Apr 17, 2018

Member

@shivtej1505 what do you think of this?

Member

dkayiwa commented Apr 17, 2018

@shivtej1505 what do you think of this?

@csmuthukuda csmuthukuda deleted the csmuthukuda:AC-377 branch May 13, 2018

@csmuthukuda csmuthukuda restored the csmuthukuda:AC-377 branch May 13, 2018

@csmuthukuda csmuthukuda reopened this May 13, 2018

@shivtej1505

This comment has been minimized.

Show comment
Hide comment
@shivtej1505

shivtej1505 May 26, 2018

Member

Good work, merging!!!
Sorry for late review.

Member

shivtej1505 commented May 26, 2018

Good work, merging!!!
Sorry for late review.

@shivtej1505 shivtej1505 merged commit 8d0603d into openmrs:master May 26, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csmuthukuda csmuthukuda deleted the csmuthukuda:AC-377 branch May 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment