New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-462:Improve Progress Dialog #425

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@csmuthukuda
Contributor

csmuthukuda commented Jun 8, 2018

This is how the new improved progress dialog looks like.
screenshot_20180609-091912

Issue Link: https://issues.openmrs.org/browse/AC-462

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Jun 19, 2018

Member

Did you see the travis build failure?
Did you also get a chance to look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips

Member

dkayiwa commented Jun 19, 2018

Did you see the travis build failure?
Did you also get a chance to look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips

@csmuthukuda

This comment has been minimized.

Show comment
Hide comment
@csmuthukuda

csmuthukuda Jun 21, 2018

Contributor

@dkayiwa, Yes I guess it's a temporary error and now with my latest PRs It didn't happen.So I will make another force push to check weather It has been fixed or not.

Contributor

csmuthukuda commented Jun 21, 2018

@dkayiwa, Yes I guess it's a temporary error and now with my latest PRs It didn't happen.So I will make another force push to check weather It has been fixed or not.

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa
Member

dkayiwa commented Jul 11, 2018

@@ -288,7 +288,7 @@ public void dismissCustomFragmentDialog() {
protected void showProgressDialog(String dialogMessage) {
CustomDialogBundle bundle = new CustomDialogBundle();
bundle.setProgressViewMessage(getString(R.string.progress_dialog_message));
// bundle.setProgressViewMessage(getString(R.string.progress_dialog_message));

This comment has been minimized.

android:layout_gravity="center_horizontal"
android:layout_toEndOf="@+id/progressBarDialog"
android:textSize="20sp" />
<!--<TextView-->
@csmuthukuda

This comment has been minimized.

Show comment
Hide comment
@csmuthukuda

csmuthukuda Jul 14, 2018

Contributor

@dkayiwa sorry for the mistake.I have updated the PR correcting them.Please review

Contributor

csmuthukuda commented Jul 14, 2018

@dkayiwa sorry for the mistake.I have updated the PR correcting them.Please review

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Jul 18, 2018

Member

@csmuthukuda did you just forget to claim the ticket?

Member

dkayiwa commented Jul 18, 2018

@csmuthukuda did you just forget to claim the ticket?

@csmuthukuda

This comment has been minimized.

Show comment
Hide comment
@csmuthukuda

csmuthukuda Jul 18, 2018

Contributor

@dkayiwa sorry I just forgot. Now I claimed it 👍

Contributor

csmuthukuda commented Jul 18, 2018

@dkayiwa sorry I just forgot. Now I claimed it 👍

int width = display.widthPixels;
WindowManager.LayoutParams params = getDialog().getWindow().getAttributes();
params.width = (width * 5 / 6) - (2 * marginWidth);

This comment has been minimized.

@shivtej1505

shivtej1505 Jul 23, 2018

Member

Did you test this on tablet and devices with unusual screen size?

@shivtej1505

shivtej1505 Jul 23, 2018

Member

Did you test this on tablet and devices with unusual screen size?

This comment has been minimized.

@csmuthukuda

csmuthukuda Jul 24, 2018

Contributor

actually, I didn't @shivtej1505..I'll do it by creating a simulator. Thank you for pointing it out.

@csmuthukuda

csmuthukuda Jul 24, 2018

Contributor

actually, I didn't @shivtej1505..I'll do it by creating a simulator. Thank you for pointing it out.

@shivtej1505

Will test it too.

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Aug 15, 2018

Member

@shivtej1505 did you get time to test it?

Member

dkayiwa commented Aug 15, 2018

@shivtej1505 did you get time to test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment