Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-467 : user details Change detection #428

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@csmuthukuda
Copy link
Contributor

csmuthukuda commented Aug 2, 2018

Currently, there is no any way to detect whether the user has been changed the user credentials from the web app. This issue will implement a new service to continuously check for user details while the application is active and log out the user if credentials have been changed.

Issue Link: https://issues.openmrs.org/browse/AC-467

@csmuthukuda csmuthukuda changed the title Ac 467 : user details Change detection AC 467 : user details Change detection Aug 2, 2018

@csmuthukuda csmuthukuda changed the title AC 467 : user details Change detection AC-467 : user details Change detection Aug 2, 2018

@f4ww4z
Copy link
Collaborator

f4ww4z left a comment

Thanks @csmuthukuda for the PR, please address my comments above.


/**
* Created by Chathuranga on 27/07/2018.
*/

This comment has been minimized.

@f4ww4z

f4ww4z Nov 19, 2018

Collaborator

Can you remove this comment? And add the OpenMRS license at line 1, like other Java files present in the code.

mOpenMRS.clearCurrentLoggedInUserInfo();
Intent intent = new Intent(getApplicationContext(), LoginActivity.class);
intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
getApplicationContext().startActivity(intent);

This comment has been minimized.

@f4ww4z

f4ww4z Nov 19, 2018

Collaborator

The user should be informed that the login credentials is incorrect anymore, before going to the Login screen. I think the user should be shown a dialog with positive and negative buttons.

This comment has been minimized.

@VANKINEENITAWRUN

VANKINEENITAWRUN Mar 11, 2019

Contributor

@f4ww4z can you please mention what would be the action of negative and positive buttons would be? or can we show a Toast or snack bar?

This comment has been minimized.

@f4ww4z

f4ww4z Mar 12, 2019

Collaborator

@VANKINEENITAWRUN so when the user's changed credentials from the web app, the user should be shown a dialog first that shows the user's credentials changed, and that he will be logged out. I think that only 1 button (text is 'OK') is needed.

@dkayiwa

This comment has been minimized.

Copy link
Member

dkayiwa commented Nov 26, 2018

@csmuthukuda did you see these merge conflicts?

@dkayiwa

This comment has been minimized.

Copy link
Member

dkayiwa commented Dec 3, 2018

@csmuthukuda are you still working on this?

@f4ww4z

This comment has been minimized.

Copy link
Collaborator

f4ww4z commented Jan 9, 2019

@csmuthukuda Ping me if you want to resume working on it.

@f4ww4z f4ww4z closed this Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.