Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
AC-400: add concepts data providers, add visit form #585
Description of what I changed
The task was to make a data provider for concepts, that can operate both REST and cache sources. Feature for concepts that was cached already implemented few years ago and the same API was used for web request (SIC! apparently that concepts feature wasn't fully correct despite it passed code review, see details in ticket comments).
I make data provider for REST call and combine it with cache. I make a visit form as PoC of concepts autopopulate feature. I extend business logic of visit form to populate with all necessary data. Altought I faced with issue to find out way to submit entered data. It should be done to make visit note business valuable.
Also I rename existing data providers from API postfix to Repository postfix as it more relevant to their current status and common naming convention.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-400
Checklist: I completed these to help reviewers :)
f4ww4z left a comment
@Gelassen Thank you for the PR! Left some comments for you to address. Also, did you pull the latest changes from the master branch? The
@Gelassen actually, I want the renaming of the Repository classes in a different issue, so that this PR is specifically for the autocompletion. I've filed this issue at AC-608, please work on that one first.