Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-402: Implement Provider Module #599

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@deepak140596
Copy link
Contributor

commented May 31, 2019

Description of what I changed

Added Provider Module. Currently it shows the Providers that are present.
Features like adding, removing providers will be added incrementally in future PRs.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-402

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.
@codecov-io

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #599 into master will increase coverage by 0.18%.
The diff coverage is 22.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   14.16%   14.35%   +0.18%     
==========================================
  Files         184      191       +7     
  Lines        8557     8752     +195     
  Branches      750      764      +14     
==========================================
+ Hits         1212     1256      +44     
- Misses       7270     7420     +150     
- Partials       75       76       +1
Impacted Files Coverage Δ
...openmrs/mobile/utilities/ApplicationConstants.java 0% <ø> (ø) ⬆️
...mobile/activities/dashboard/DashboardFragment.java 0% <0%> (ø) ⬆️
...es/providermanager/ProviderManagementActivity.java 0% <0%> (ø)
...es/providermanager/ProviderManagementFragment.java 0% <0%> (ø)
...manager/ProviderManagementRecyclerViewAdapter.java 0% <0%> (ø)
.../main/java/org/openmrs/mobile/dao/ProviderDAO.java 0% <0%> (ø)
...ava/org/openmrs/mobile/databases/DBOpenHelper.java 12.76% <11.11%> (+0.03%) ⬆️
...openmrs/mobile/databases/tables/ProviderTable.java 33.33% <33.33%> (ø)
.../main/java/org/openmrs/mobile/models/Provider.java 43.33% <43.33%> (ø)
...s/providermanager/ProviderManagementPresenter.java 67.64% <67.64%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99496f8...9852d83. Read the comment docs.

@deepak140596 deepak140596 force-pushed the deepak140596:Provider_Module branch from 5dcf37f to 831128a Jun 1, 2019

@deepak140596 deepak140596 force-pushed the deepak140596:Provider_Module branch from 7ad1dd9 to 9852d83 Jun 1, 2019

@f4ww4z

This comment has been minimized.

Copy link
Collaborator

commented Jun 2, 2019

@deepak140596 I recommend that you split the issue into subtasks on JIRA. It will be easier to review.

@deepak140596

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

Ok @f4ww4z . I will create subtasks on JIRA and then create PR for the subsequent changes here.
Do I need to change current PR (like close it and open with small tasks) or create small tasks after this PR is reviewed and merged?

@deepak140596

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

will update it with MVVM architecture. And also update the work in small tasks.

@deepak140596 deepak140596 deleted the deepak140596:Provider_Module branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.