Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLAS-168: Notify users when their marker is fading #101

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@HelioStrike
Copy link
Collaborator

commented Jul 18, 2019

@HelioStrike HelioStrike requested review from bmamlin and cintiadr Jul 18, 2019

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-168 branch 4 times, most recently from d4713c7 to 1af776f Jul 18, 2019

@HelioStrike

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2019

@bmamlin I updated the PR. What do you think of the new tables? I haven't written code to handle the email links, but I'll try to finish it tomorrow.

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-168 branch 3 times, most recently from 1fcdb94 to d77bfb2 Jul 20, 2019

CREATE TABLE `notifications` (
`id` int(10) unsigned NOT NULL AUTO_INCREMENT,
`marker_id` varchar(38) COLLATE utf8_unicode_ci NOT NULL,
`principal` varchar(255) COLLATE utf8_unicode_ci NOT NULL,

This comment has been minimized.

Copy link
@bmamlin

bmamlin Jul 20, 2019

Member

principal is a security term used in the auth table to cover authentication of users & non-users. For notifications & unsubscribed, I'd suggest using username.

CREATE TABLE `unsubscribed` (
`id` int(10) unsigned NOT NULL AUTO_INCREMENT,
`marker_id` varchar(38) COLLATE utf8_unicode_ci NOT NULL,
`principal` varchar(255) COLLATE utf8_unicode_ci NOT NULL,

This comment has been minimized.

Copy link
@bmamlin

bmamlin Jul 20, 2019

Member

Use username instead of principal per comment above.

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-168 branch 7 times, most recently from 411d1ae to ab126eb Jul 21, 2019

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-168 branch from bf618d4 to e8a493f Jul 22, 2019

@HelioStrike

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2019

@bmamlin @cintiadr Updated the PR with all the changes suggested on Talk. I tested it on stg (
with a much lower mail timeout, and only sending mails to me), and it seems to be working fine.

Screenshot from 2019-07-22 21-26-30

@HelioStrike HelioStrike requested a review from bmamlin Jul 22, 2019

@bmamlin bmamlin merged commit 9b2c64f into openmrs:master Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.