Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLAS-169: Added search for markers #114

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@HelioStrike
Copy link
Collaborator

commented Aug 7, 2019

JIRA issue: https://issues.openmrs.org/browse/ATLAS-169

The markers' names are checked to see if they contain the search term as a substring. If no, the sites are hidden. Clicking search displays a clear button which can be clicked to revert the map to normal. Is there anything that you'd like to improve about the PR?

The changes can be tested on staging.

Screenshot from 2019-08-07 13-34-49

@HelioStrike HelioStrike requested review from bmamlin and cintiadr Aug 7, 2019

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-169 branch 9 times, most recently from 94dd476 to 80a3bee Aug 12, 2019

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-169 branch from 80a3bee to 2fb544b Aug 17, 2019

@bmamlin

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Awesome work, @HelioStrike!

@bmamlin bmamlin merged commit 73e91d7 into openmrs:master Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.