Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added authentication check for post routes #41

Merged
merged 1 commit into from Mar 20, 2019

Conversation

@HelioStrike
Copy link
Collaborator

commented Mar 19, 2019

Based on this issue. Weirdly, I couldn't test the code I wrote, as the '/login/' route leads to 'http://localhost:8080/authenticate/atlas' which I don't know how to set up. If I can get that url running, I think I could test and confirm whether my code does the job.

@cintiadr

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

I don't mind merging this PR at all, but bear in mind that login is not working 💃

@HelioStrike

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 19, 2019

@cintiadr Since it has to be implemented at some point, I think the PR should be merged. Well, then again, since its my code, I'm quite biased. :P
What do you think?

@cintiadr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

You know what, sure, I'm fairly sure if it broke something, we'll have to fix!

@cintiadr cintiadr merged commit a1dd1eb into openmrs:3.x Mar 20, 2019

@HelioStrike

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 20, 2019

Holy moly. I was pretty busy and stressed out yesterday that somehow I forgot that adding the authentication routes might mean that code elsewhere using it may no longer be able to do so. Sorry about that.
I hope it didn't break anything, but yup, if anything does break, we'll have to fix. :)

@cintiadr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Well, it's not more broken now than it was before, so it's fine. Not really going to keep me awake at night.

@dkayiwa

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@cintiadr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

That’s on me, @dkayiwa.

I deleted the staging server.

@HelioStrike HelioStrike deleted the HelioStrike:3.x-postauth branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.