Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLAS-134: Check and store whether user is admin on login #46

Merged
merged 1 commit into from Jun 8, 2019

Conversation

@HelioStrike
Copy link
Collaborator

commented Jun 4, 2019

@cintiadr @bmamlin @harsha89 Whether the user is an admin or not is now stored in the user session object.

Here's a sample user session object.

{ dn: 'uid=testadmin,ou=users,dc=openmrs,dc=org',
  controls: [],
  uid: 'testadmin',
  cn: 'Admin',
  sn: 'User',
  displayName: 'Test Admin User',
  mail: 'testadminuser@gmail.com',
  admin: true }

I'm starting to think that maybe a flag wouldn't be the best idea if the user belonged to multiple groups. Maybe its better to ignore that for now, as mentioned my @bmamlin on talk yesterday. What do you think? :)

@cintiadr cintiadr self-requested a review Jun 6, 2019

ldap.js Show resolved Hide resolved

@cintiadr cintiadr requested review from bmamlin and harsha89 Jun 6, 2019

ldap.js Outdated Show resolved Hide resolved
ldap.js Show resolved Hide resolved
ldap.js Outdated Show resolved Hide resolved

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-134 branch 2 times, most recently from ecf0b30 to 018c483 Jun 7, 2019

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-134 branch from 018c483 to d0a619f Jun 7, 2019

@bmamlin bmamlin merged commit 9820d12 into openmrs:3.x Jun 8, 2019

@HelioStrike HelioStrike deleted the HelioStrike:ATLAS-134 branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.