Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLAS-146: Improve the styling of the Atlas Login page #56

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@HelioStrike
Copy link
Collaborator

commented Jun 13, 2019

Borrowed code from OpenMRS ID login to make the Atlas login look like it.

JIRA issue: https://issues.openmrs.org/browse/ATLAS-146?jql=project%20%3D%20ATLAS

Screenshot from 2019-06-13 22-21-28

@HerbertYiga

This comment has been minimized.

Copy link

commented Jun 14, 2019

you can append your snap shots to the JIRA ticket as advised here https://wiki.openmrs.org/display/docs/Pull+Request+Tips

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-146 branch from 6df4011 to d746fc0 Jun 14, 2019

@HelioStrike

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2019

@HerbertYiga done :)

@cintiadr cintiadr requested review from cintiadr and bmamlin Jun 16, 2019

@cintiadr

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2019

Well, that's way too similar, scarily too identical.
Can you remove the text at the top ('your openmrsid is the key blablabla') and the footer ('Need help and everything below).

@HelioStrike HelioStrike force-pushed the HelioStrike:ATLAS-146 branch from d746fc0 to bfcae9f Jun 16, 2019

@HelioStrike

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 16, 2019

@cintiadr done :)

@cintiadr
Copy link
Contributor

left a comment

The screen can be simplified as per comment before :)

@HelioStrike

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 16, 2019

@cintiadr

Can you remove the text at the top ('your openmrsid is the key blablabla') and the footer ('Need help and everything below).

I believe I pushed the change. Here's the new screen.

Screenshot from 2019-06-16 11-53-43

@bmamlin

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

@cintiadr, Atlas (like Discourse and Desk.com) had been configured for SSO against OpenMRS ID. Can we still use this (as we are for Talk)? It seems better to leverage OpenMRS ID's login page instead of duplicating it.

@cintiadr

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@bmamlin , SSO in ID broke a couple of years ago for both Desk.com and Atlas. To be fair, looking at the whole thing, it's a surprise it's still working for talk, and I'm not going to be surprised when it stops working. We don't maintain the code, we don't have anyone knowledgeable on the security implications of the decisions we took, we don't apply not even security patches to that code. I don't think I can even be bothered to try to understand that, as the person who originally pushed for build-your-own SSO said they won't help us at all investigate the problem.

This is a stepping stop to get less reliant on ID, so I can actually try to replace ID and Crowd with something else. But allows atlas to work for the time being.

I don't want things to go straight to ldap for too long, but it's my way of decomposing the problem in a way we can replace the engine without crashing the plane.

@cintiadr

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

And getting rid of the broken SSO in ID in Desk.com was surprisingly hard. Atlas login haven't been working all this time because ID upgrade broke the SSO catastrophically. And really, I won't bother investigating and fixing such problems in a system it's not supported, I have no evidence of its security, it was incredibly unreliable and wasn't production ready when I started taking care of it.

It's a waste of resources.

@bmamlin bmamlin merged commit e98c8ba into openmrs:3.x Jun 24, 2019

@HelioStrike HelioStrike deleted the HelioStrike:ATLAS-146 branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.