diff --git a/api/src/main/java/org/openmrs/Cohort.java b/api/src/main/java/org/openmrs/Cohort.java index 41b7d31d7000..3acbead18ea2 100644 --- a/api/src/main/java/org/openmrs/Cohort.java +++ b/api/src/main/java/org/openmrs/Cohort.java @@ -9,6 +9,8 @@ */ package org.openmrs; +import org.apache.commons.lang3.StringUtils; + import java.util.Arrays; import java.util.Collection; import java.util.Date; @@ -16,8 +18,6 @@ import java.util.TreeSet; import java.util.stream.Collectors; -import org.apache.commons.lang3.StringUtils; - /** * This class represents a list of patientIds. */ @@ -160,7 +160,7 @@ public boolean addMember(Integer memberId) { * @since 2.1.0 */ public boolean addMembership(CohortMembership cohortMembership) { - if (cohortMembership != null && !this.contains(cohortMembership.getPatientId())) { + if (cohortMembership != null) { cohortMembership.setCohort(this); return getMemberships().add(cohortMembership); } @@ -338,11 +338,8 @@ public Set getMemberIds() { @Deprecated public void setMemberIds(Set memberIds) { if (getMemberships().size() == 0) { - Date startDate = new Date(); for (Integer id : memberIds) { - CohortMembership membership = new CohortMembership(id, startDate); - membership.setCohort(this); - getMemberships().add(membership); + addMembership(new CohortMembership(id)); } } else {