New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added send mail functionality to send token via mail #2701

Merged
merged 9 commits into from Aug 31, 2018

Conversation

Projects
None yet
3 participants
@fanyui
Contributor

fanyui commented Aug 13, 2018

Description of what I changed

Add possibility for sending email with activation key

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-

Checklist: I completed these to help reviewers :)

  • [ x] My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).

    No? -> read here on how to squash multiple commits into one

  • [ x] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [x ] I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ x] I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • [ x] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@fanyui

This comment has been minimized.

Show comment
Hide comment
@fanyui

fanyui Aug 13, 2018

Contributor

@wluyima This pull request sends the emai with generated activation key. so we can use it to test the rest webservice endpoint.

Contributor

fanyui commented Aug 13, 2018

@wluyima This pull request sends the emai with generated activation key. so we can use it to test the rest webservice endpoint.

@fanyui

This comment has been minimized.

Show comment
Hide comment
@fanyui

fanyui Aug 17, 2018

Contributor

@wluyima Ive done some updates on this, Please how should the message be structured. so that is can support localization.

Contributor

fanyui commented Aug 17, 2018

@wluyima Ive done some updates on this, Please how should the message be structured. so that is can support localization.

@wluyima

This comment has been minimized.

Show comment
Hide comment
@wluyima

wluyima Aug 17, 2018

Member

Let's not do localization for now, it will be done in the future

Member

wluyima commented Aug 17, 2018

Let's not do localization for now, it will be done in the future

Created message using message service and removed default HOST_URL GP…
… also removed useless global property configuration from userservicetest
@wluyima

This comment has been minimized.

Show comment
Hide comment
@wluyima

wluyima Aug 24, 2018

Member

@fanyui are you still working on this?

Member

wluyima commented Aug 24, 2018

@fanyui are you still working on this?

@fanyui

This comment has been minimized.

Show comment
Hide comment
@fanyui

fanyui Aug 25, 2018

Contributor

@wluyima Yes am still working on it sorry for the absence, I had a fever(maleria) but have recovered. If am no longer working on a ticket i will identify.

Contributor

fanyui commented Aug 25, 2018

@wluyima Yes am still working on it sorry for the absence, I had a fever(maleria) but have recovered. If am no longer working on a ticket i will identify.

migrate the strings responsible for creating an email message to mess…
…ages.properties file also added duration of the reset valid link in the mail content
@fanyui

This comment has been minimized.

Show comment
Hide comment
@fanyui

fanyui Aug 30, 2018

Contributor

@wluyima I have fixed this could you take a look?

Contributor

fanyui commented Aug 30, 2018

@wluyima I have fixed this could you take a look?

@wluyima wluyima merged commit 4f15380 into openmrs:passwordreset Aug 31, 2018

6 of 7 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
security/snyk - api/pom.xml (openmrs) No new issues
Details
security/snyk - pom.xml (openmrs) No new issues
Details
security/snyk - test/pom.xml (openmrs) No new issues
Details
security/snyk - tools/pom.xml (openmrs) No new issues
Details
security/snyk - web/pom.xml (openmrs) No new issues
Details
security/snyk - webapp/pom.xml (openmrs) No new issues
Details
@wluyima

This comment has been minimized.

Show comment
Hide comment
@wluyima

wluyima Aug 31, 2018

Member

Thanks @fanyui !

Member

wluyima commented Aug 31, 2018

Thanks @fanyui !

@fanyui

This comment has been minimized.

Show comment
Hide comment
@fanyui

fanyui Sep 7, 2018

Contributor

@wluyima Am grateful for all the support, and eye opening all-through.

Contributor

fanyui commented Sep 7, 2018

@wluyima Am grateful for all the support, and eye opening all-through.

@wluyima

This comment has been minimized.

Show comment
Hide comment
@wluyima

wluyima Sep 7, 2018

Member

👍

Member

wluyima commented Sep 7, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment