Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5528:Upgrade org.apache.lucene sub Libraries #3121

Open
wants to merge 1 commit into
base: master
from

Conversation

@jwnasambu
Copy link
Contributor

jwnasambu commented Feb 6, 2020

Description of what I changed

I upgraded library org.apache.lucene sub Libraries

org.apache.lucene:lucene-queries … 4.10.4 -> 5.3.1
org.apache.lucene:lucene-queryparser … 4.10.4 -> 5.3.1

Issue I worked on

https://issues.openmrs.org/browse/TRUNK-5528

@dkayiwa

This comment has been minimized.

Copy link
Member

dkayiwa commented Feb 14, 2020

Did you take a look at the travis build failure?

@mozzy11

This comment has been minimized.

Copy link
Member

mozzy11 commented Feb 17, 2020

@jwnasambu you may need to read the Migration Guide to handle the backward incompatibilty in this library https://lucene.apache.org/core/5_0_0/MIGRATE.html

@jwnasambu

This comment has been minimized.

Copy link
Contributor Author

jwnasambu commented Feb 17, 2020

@mozzy11 thank you am actually reading hard through it.

@jwnasambu

This comment has been minimized.

Copy link
Contributor Author

jwnasambu commented Feb 17, 2020

@dkayiwa I saw the failure and I was researching on the cause and this is my conclusion concerning Travis CI failure. Lucene 5 by default only read indexes created with Lucene 5. To read and upgrade Lucene 4.x (4.10.4)indexes, I must add the lucene-backward-codecs.jar to the classpath. for it is recommended to upgrade the old indexes with the IndexUpgrader tool, so as to remove the backward-codecs module from classpath to improve performance.

@jwnasambu jwnasambu force-pushed the jwnasambu:TRUNK-5528 branch from f5a3c38 to 795e2c6 Feb 20, 2020
Copy link
Contributor

anshulbh9 left a comment

@jwnasambu for upgrading apache.lucene you should also upgrade hibernate-search as both libraries depend on each other and also look for compatibility of both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.