TRUNK-6223 - RequiredDataAdvice should validate after save handlers e… #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseaton
commented
Feb 15, 2024
| PersonAddress pa = Context.getPersonService().getPersonAddressByUuid("3350d0b5-821c-4e5e-ad1d-a9bce331e118"); | ||
| pa.setVoided(true); | ||
| pa.setVoidReason(null); | ||
| Context.getPersonService().savePersonAddress(pa); |
There was a problem hiding this comment.
This test as written didn't make a lot of sense. Not sure y it is setting void reason twice. In any event, the PersonValidator has an explicit check to ensure the void reason is non-null, and based on the name of this test method, the idea is to ensure you can leave void reason null for types other than Patient and Encounter, so I changed this to PersonAddress and things work fine.
mogoodrich
approved these changes
Feb 15, 2024
dkayiwa
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xecute
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6223