Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): Fix medications details table overflow menu #547

Merged
merged 1 commit into from Feb 11, 2022
Merged

(fix): Fix medications details table overflow menu #547

merged 1 commit into from Feb 11, 2022

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Move the data-floating-menu-container attribute higher up to the TableContainer so the overflow menu gets placed appropriately in the DOM.

Screenshots

Before

Notice how the overflow menu items don't get overlaid on top of the DataTable. The user needs to scroll down to see all of the menu items.

Screenshot 2022-02-10 at 21 58 06

After

Overflow menu items get properly overlaid over the DataTable.

Screenshot 2022-02-10 at 21 57 31

@denniskigen denniskigen changed the title Fix medications details table overflow menu (fix): Fix medications details table overflow menu Feb 10, 2022
@github-actions
Copy link
Contributor

File size impact

Merging overflow-menu-fix into master impact files as follow:

@openmrs/esm-form-entry-app (no impact)
Files new size
Unmodified (4) 1.47 MB (0 B / +0%) 👻
Total (4) 1.47 MB (0 B / +0%) 👻
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (16) 2.92 MB (0 B / +0%) 👻
Total (16) 2.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (33) 2.58 MB (0 B / +0%) 👻
Total (33) 2.58 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (25) 2.06 MB (0 B / +0%) 👻
Total (25) 2.06 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (22) 1.61 MB (0 B / +0%) 👻
Total (22) 1.61 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (17) 1.01 MB (0 B / +0%) 👻
Total (17) 1.01 MB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (22) 2.54 MB (0 B / +0%) 👻
Total (22) 2.54 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (no impact)
Files new size
Unmodified (40) 3.55 MB (0 B / +0%) 👻
Total (40) 3.55 MB (0 B / +0%) 👻
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (19) 1.42 MB (0 B / +0%) 👻
Total (19) 1.42 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (26) 1.91 MB (0 B / +0%) 👻
Total (26) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (25) 1.98 MB (0 B / +0%) 👻
Total (25) 1.98 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (23) 1.82 MB (0 B / +0%) 👻
Total (23) 1.82 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (-0%)
Files new size
packages/esm-patient-medications-app/dist/819.js 135 kB (-3 B / -0%) ↘️
Unmodified (19) 2.65 MB (0 B / +0%) 👻
Total (20) 2.78 MB (-3 B / -0%) ↘️
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (25) 1.85 MB (0 B / +0%) 👻
Total (25) 1.85 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (23) 1.87 MB (0 B / +0%) 👻
Total (23) 1.87 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (28) 3.78 MB (0 B / +0%) 👻
Total (28) 3.78 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (26) 3.49 MB (0 B / +0%) 👻
Total (26) 3.49 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1825655168 on 5a999ea

@github-actions
Copy link
Contributor

File size impact

Merging overflow-menu-fix into master impact files as follow:

@openmrs/esm-form-entry-app (no impact)
Files new size
Unmodified (4) 1.47 MB (0 B / +0%) 👻
Total (4) 1.47 MB (0 B / +0%) 👻
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (16) 2.92 MB (0 B / +0%) 👻
Total (16) 2.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (33) 2.58 MB (0 B / +0%) 👻
Total (33) 2.58 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (25) 2.06 MB (0 B / +0%) 👻
Total (25) 2.06 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (22) 1.61 MB (0 B / +0%) 👻
Total (22) 1.61 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (17) 1.01 MB (0 B / +0%) 👻
Total (17) 1.01 MB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (22) 2.54 MB (0 B / +0%) 👻
Total (22) 2.54 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (no impact)
Files new size
Unmodified (40) 3.55 MB (0 B / +0%) 👻
Total (40) 3.55 MB (0 B / +0%) 👻
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (19) 1.42 MB (0 B / +0%) 👻
Total (19) 1.42 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (26) 1.91 MB (0 B / +0%) 👻
Total (26) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (25) 1.98 MB (0 B / +0%) 👻
Total (25) 1.98 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (23) 1.82 MB (0 B / +0%) 👻
Total (23) 1.82 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (-0%)
Files new size
packages/esm-patient-medications-app/dist/819.js 135 kB (-3 B / -0%) ↘️
Unmodified (19) 2.65 MB (0 B / +0%) 👻
Total (20) 2.78 MB (-3 B / -0%) ↘️
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (25) 1.85 MB (0 B / +0%) 👻
Total (25) 1.85 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (23) 1.87 MB (0 B / +0%) 👻
Total (23) 1.87 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (26) 3.49 MB (0 B / +0%) 👻
Total (26) 3.49 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (28) 3.78 MB (0 B / +0%) 👻
Total (28) 3.78 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1825645483 on 5a999ea

@jonathandick jonathandick merged commit f4aa611 into master Feb 11, 2022
@denniskigen denniskigen deleted the overflow-menu-fix branch February 11, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathandick jonathandick jonathandick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@denniskigen @jonathandick