New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-1937: Write E2E test for Patient List #578
Conversation
894bc8f
to
39cce87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Piumal1999, thanks for the excellent work. Would you like more help fixing some QA issues??
Finally, this is ready for merging. @jayasanka-sack @anjula-sack Could you please review and merge this PR? |
@@ -141,6 +141,7 @@ const CreateEditPatientList: React.FC<CreateEditPatientListProps> = ({ | |||
<div className={styles.input}> | |||
<Layer level={isTablet ? 1 : 0}> | |||
<TextArea | |||
id="list_description" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this Id? @Piumal1999
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anjula-sack For some reason, playwright fails to locate the textarea by label if the id is not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requirements
Summary
Created the following E2E Tests for esm-patient-list app.
Related Doc: https://docs.google.com/document/d/1qD_zpYUG8C28zoAhrl7slI55lInyO7a-QR3tiwhrjwk/edit#heading=h.swr4izgpg4my
Screenshots
Related Issue
https://issues.openmrs.org/projects/O3/issues/O3-1937
Other
Update: This bug is fixed and the PR is ready for review