Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1937: Write E2E test for Patient List #578

Merged
merged 16 commits into from Apr 9, 2023

Conversation

Piumal1999
Copy link
Collaborator

@Piumal1999 Piumal1999 commented Mar 2, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Created the following E2E Tests for esm-patient-list app.

  • Creating and editing a patient list
  • Deleting a patient list
  • Managing patients in a patient list

Related Doc: https://docs.google.com/document/d/1qD_zpYUG8C28zoAhrl7slI55lInyO7a-QR3tiwhrjwk/edit#heading=h.swr4izgpg4my

Screenshots

image

Related Issue

https://issues.openmrs.org/projects/O3/issues/O3-1937

Other

⚠️ Do not merge this PR or run the tests until COH-51 is fixed. Otherwise, it will fail to delete the created patient lists and cohort types.

Update: This bug is fixed and the PR is ready for review

@Piumal1999 Piumal1999 force-pushed the O3-1937 branch 2 times, most recently from 894bc8f to 39cce87 Compare March 2, 2023 19:18
@Piumal1999 Piumal1999 marked this pull request as ready for review March 6, 2023 18:16
@Piumal1999 Piumal1999 marked this pull request as draft March 6, 2023 18:17
Copy link
Contributor

@Jexsie Jexsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Piumal1999, thanks for the excellent work. Would you like more help fixing some QA issues??

@Piumal1999 Piumal1999 marked this pull request as ready for review April 8, 2023 09:03
@Piumal1999
Copy link
Collaborator Author

Finally, this is ready for merging. @jayasanka-sack @anjula-sack Could you please review and merge this PR?

@@ -141,6 +141,7 @@ const CreateEditPatientList: React.FC<CreateEditPatientListProps> = ({
<div className={styles.input}>
<Layer level={isTablet ? 1 : 0}>
<TextArea
id="list_description"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this Id? @Piumal1999

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjula-sack For some reason, playwright fails to locate the textarea by label if the id is not defined.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay

Copy link
Collaborator

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anjula-sack anjula-sack merged commit a725fd5 into openmrs:main Apr 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants