RA-1865: Fix possible xss in account setup #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Why?
Possible XSS bug identified by NC State team in account setup pages
What Changed?
Added HTML encoding before user-controlled variables such as username are added to the model.
Decisions Made
Decided to do the most aggressive html-encoding because the values in question should not have any html-encodable characters anyway. In the unlikely event that this causes anything to break, though, more targeted xss prevention can be done in the .gsp frontend