New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA-1503 Added implementation to store the session location in userContext #19

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@suthagar23
Member

suthagar23 commented Jun 10, 2018

Description

Logged-in user session information can be fetched only from the web layer. If we want to get the currently logged-in user location information, then we need to call a given REST API .

This implementation will keep the logged-in user session location information into the UserContext to extend the API level usage.

Ticket Information

Ticket : https://issues.openmrs.org/browse/RA-1503

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Jun 19, 2018

Member

Can you look at the above travis failure?

Member

dkayiwa commented Jun 19, 2018

Can you look at the above travis failure?

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Jun 20, 2018

Member

@suthagar23 did you see the above comment?

Member

dkayiwa commented Jun 20, 2018

@suthagar23 did you see the above comment?

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Jun 26, 2018

Member

@suthagar23 did you see these comments?

Member

dkayiwa commented Jun 26, 2018

@suthagar23 did you see these comments?

@suthagar23

This comment has been minimized.

Show comment
Hide comment
@suthagar23

suthagar23 Jun 27, 2018

Member

Ohh Sorry, I will fix it soon

Member

suthagar23 commented Jun 27, 2018

Ohh Sorry, I will fix it soon

@suthagar23

This comment has been minimized.

Show comment
Hide comment
@suthagar23

suthagar23 Jun 28, 2018

Member

@dkayiwa I have fixed it. Please have a look again.

Member

suthagar23 commented Jun 28, 2018

@dkayiwa I have fixed it. Please have a look again.

Suthagar23
Added implementation to store the session location in userContext
Added minor changes for testing

Minor modifications

Minor fix

Removed function and merged with existing function

Minor fix

@suthagar23 suthagar23 changed the title from Added implementation to store the session location in userContext to RA-1503 Added implementation to store the session location in userContext Jun 28, 2018

@@ -82,6 +82,9 @@ public void setSessionLocation(Location sessionLocation) {
}
this.sessionLocation = sessionLocation;
this.sessionLocationId = sessionLocation.getId();
if (userContext != null && userContext.getAuthenticatedUser() != null) {

This comment has been minimized.

@dkayiwa

dkayiwa Jun 28, 2018

Member

Does this also cater for the case where i just switch location when am already logged in?

@dkayiwa

dkayiwa Jun 28, 2018

Member

Does this also cater for the case where i just switch location when am already logged in?

This comment has been minimized.

@suthagar23

suthagar23 Jun 28, 2018

Member

Yes, It will immediately swtich the location when you already logged in.

@suthagar23

suthagar23 Jun 28, 2018

Member

Yes, It will immediately swtich the location when you already logged in.

@dkayiwa dkayiwa merged commit 992b9ad into openmrs:master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment