New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBAC-2 Added implementation to add the locations to the users on registration #17

Merged
merged 1 commit into from Jul 24, 2018

Conversation

Projects
None yet
2 participants
@suthagar23
Member

suthagar23 commented Jul 20, 2018

Description

This PR contains the implementation to assign the location to the users on registration. It contains two custom fragments for,

  • Add/Edit the location in the user dashboard
  • View the location information in the user dashboard

Ticket

Ticket : https://issues.openmrs.org/browse/LBAC-2

@@ -1,3 +1,4 @@
${project.parent.artifactId}.title=Location based access control module
locationbasedaccess.patientLocation=Patient Location

This comment has been minimized.

@dkayiwa

dkayiwa Jul 22, 2018

Member

Are we still using locationbasedaccess.patientLocation for anything?

@dkayiwa

dkayiwa Jul 22, 2018

Member

Are we still using locationbasedaccess.patientLocation for anything?

This comment has been minimized.

@suthagar23

suthagar23 Jul 23, 2018

Member

For showing the label on the patient registration dashboard.

@suthagar23

suthagar23 Jul 23, 2018

Member

For showing the label on the patient registration dashboard.

@@ -3,7 +3,7 @@
<div>
<p class="left">
<label>
Please select the location

This comment has been minimized.

@dkayiwa

dkayiwa Jul 24, 2018

Member

Can we drop the "Please select the"? and just use Location?

@dkayiwa

dkayiwa Jul 24, 2018

Member

Can we drop the "Please select the"? and just use Location?

This comment has been minimized.

@dkayiwa

dkayiwa Jul 24, 2018

Member

The same applies else where you use please select the location instead of just Location

@dkayiwa

dkayiwa Jul 24, 2018

Member

The same applies else where you use please select the location instead of just Location

This comment has been minimized.

@suthagar23

suthagar23 Jul 24, 2018

Member

@dkayiwa I have changed that to location.

@suthagar23

suthagar23 Jul 24, 2018

Member

@dkayiwa I have changed that to location.

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Jul 24, 2018

Member

Did you also change the extension ids?

Member

dkayiwa commented Jul 24, 2018

Did you also change the extension ids?

@suthagar23

This comment has been minimized.

Show comment
Hide comment
@suthagar23
Member

suthagar23 commented Jul 24, 2018

@dkayiwa

This comment has been minimized.

Show comment
Hide comment
@dkayiwa

dkayiwa Jul 24, 2018

Member

In the docs, i still see something like createUser.customFragments.userLocation

Member

dkayiwa commented Jul 24, 2018

In the docs, i still see something like createUser.customFragments.userLocation

Suthagar23
LBAC-2 Added implementation to add the locations to the users on regi…
…stration

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

@dkayiwa dkayiwa merged commit 4faaa2f into openmrs:master Jul 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

suthagar23 added a commit to suthagar23/openmrs-module-locationbasedaccess that referenced this pull request Jul 27, 2018

LBAC-2 Added implementation to add the locations to the users on regi…
…stration (#17)

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

PR review fixes

LBAC-13 Added implementation to create RefApp location glopal property

LBAC-13 Added implementation to create RefApp location glopal property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment