Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new module for Location based access control project #5

Merged
merged 1 commit into from May 24, 2018

Conversation

@suthagar23
Copy link
Member

@suthagar23 suthagar23 commented May 24, 2018

Description

This is an initial PR which contains the basic files for the module.

Ticket

Ticket : Ticekt : https://issues.openmrs.org/browse/LBAC-4

Others

  • I was able to compile the project without any failures.
@@ -0,0 +1,5 @@
<org.openmrs.module.emrapi.metadata.MetadataPackagesConfig>
<packages>
Copy link
Member

@dkayiwa dkayiwa May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file part of the auto generated project?

Loading


@Test
public void testSavePatient() {

Copy link
Member

@dkayiwa dkayiwa May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file part of the auto generated project?

Loading

pom.xml Outdated

<properties>
<openMRSVersion>2.0.5</openMRSVersion>
<appuiVersion>1.8.0</appuiVersion>
Copy link
Member

@dkayiwa dkayiwa May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was appuiVersion part of the auto generated project?

Loading

@suthagar23
Copy link
Member Author

@suthagar23 suthagar23 commented May 24, 2018

@dkayiwa I have fixed those minor issues. Could you please have a look again?

Loading

@@ -0,0 +1,68 @@
/**
* The contents of this file are subject to the OpenMRS Public License
* Version 1.0 (the "License"); you may not use this file except in
Copy link
Member

@dkayiwa dkayiwa May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an old version of the license.

Loading

@dkayiwa
Copy link
Member

@dkayiwa dkayiwa commented May 24, 2018

I still see api/src/main/resources/packages.xml in the commit

Loading

Minor modification

Minor modifications

Added new OpenMRS license header
@suthagar23
Copy link
Member Author

@suthagar23 suthagar23 commented May 24, 2018

@dkayiwa I have removed and updated with the new license header(2.0)

Loading

@dkayiwa dkayiwa merged commit 6dbd5a2 into openmrs:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants