Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new module for Location based access control project #5

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
2 participants
@suthagar23
Copy link
Member

suthagar23 commented May 24, 2018

Description

This is an initial PR which contains the basic files for the module.

Ticket

Ticket : Ticekt : https://issues.openmrs.org/browse/LBAC-4

Others

  • I was able to compile the project without any failures.

@suthagar23 suthagar23 force-pushed the suthagar23:LBAC-4 branch from 109731b to e1d11d3 May 24, 2018

@@ -0,0 +1,5 @@
<org.openmrs.module.emrapi.metadata.MetadataPackagesConfig>
<packages>

This comment has been minimized.

@dkayiwa

dkayiwa May 24, 2018

Member

Was this file part of the auto generated project?


@Test
public void testSavePatient() {

This comment has been minimized.

@dkayiwa

dkayiwa May 24, 2018

Member

Was this file part of the auto generated project?

pom.xml Outdated

<properties>
<openMRSVersion>2.0.5</openMRSVersion>
<appuiVersion>1.8.0</appuiVersion>

This comment has been minimized.

@dkayiwa

dkayiwa May 24, 2018

Member

Was appuiVersion part of the auto generated project?

@suthagar23 suthagar23 force-pushed the suthagar23:LBAC-4 branch from e1d11d3 to da41bac May 24, 2018

@suthagar23

This comment has been minimized.

Copy link
Member Author

suthagar23 commented May 24, 2018

@dkayiwa I have fixed those minor issues. Could you please have a look again?

@@ -0,0 +1,68 @@
/**
* The contents of this file are subject to the OpenMRS Public License
* Version 1.0 (the "License"); you may not use this file except in

This comment has been minimized.

@dkayiwa

dkayiwa May 24, 2018

Member

This is an old version of the license.

@dkayiwa

This comment has been minimized.

Copy link
Member

dkayiwa commented May 24, 2018

I still see api/src/main/resources/packages.xml in the commit

Suthagar23
Created new module for Location based access control project
Minor modification

Minor modifications

Added new OpenMRS license header

@suthagar23 suthagar23 force-pushed the suthagar23:LBAC-4 branch from da41bac to 930f8cb May 24, 2018

@suthagar23

This comment has been minimized.

Copy link
Member Author

suthagar23 commented May 24, 2018

@dkayiwa I have removed and updated with the new license header(2.0)

@dkayiwa dkayiwa merged commit 6dbd5a2 into openmrs:master May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.