Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-164 #69

Open
wants to merge 3 commits into
base: master
from

Conversation

@extremobemo
Copy link

commented Apr 11, 2019

CB-164 Adding version number to bundled OWA file name

Description of what I changed

Added an OWA Util that will strip the version number from a bundled OWA if the version number is present.

Another PR in generator-openmrs-owa by the same name (CB-164) allows for newly generated OWA's to contain the version number in the filename when packaged.

Issue I worked on

see https://issues.openmrs.org/browse/CB-164

Checklist:

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).

    No? -> read here on how to squash multiple commits into one

  • My IDE is configured to follow the code style of this project.

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

Strip version number from OWAs URL if present.
- Wrote new method to strip version number from bundled OWAs.
- Included tests.
- This PR is dependent on another PR in `generator-openmrs-owa` by the same name, `CB-164`, which adds version number to newly generated OWAs.
@dkayiwa

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Can you include the ticket id in the commit message as advised here? https://wiki.openmrs.org/display/docs/Pull+Request+Tips

extremobemo added 2 commits Apr 10, 2019
[CB-164] Strip version number from OWAs URL if present.
- Wrote new method to strip version number from bundled OWAs.
- Included tests.
- This PR is dependent on another PR in `generator-openmrs-owa` by the same name, `CB-164`, which adds version number to newly generated OWAs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.