RA-1516 Added support to select the location from the userProperty in the Login Screen #47

suthagar23 · 2018-07-26T12:05:31Z

Description

This PR contains the changes to select the session location from userProperty in the login screen. It will be worked according to these following steps,

It will check for the Global property(GP) called "referenceapplication.locationUserPropertyName".
If the GP has the value, then it will hide the location selector from the login screen
When users try to log in, it will fetch the location from the user property
If the respected user doesn't have the required user property, then it will redirect to the usual login screen(with login selector) to select the location

Ticket

Ticket : https://issues.openmrs.org/browse/RA-1516

dkayiwa · 2018-07-26T12:36:02Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java


+			//TODO uncomment this to replace the if clause after it


When do you plan to work on the above TODO?

Actually this was came from the exiting code. I just moved that whole part. Do you want me to clear this as well?

Just removed @dkayiwa

dkayiwa · 2018-07-26T15:20:27Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

-	                  @SpringBean("locationService") LocationService locationService,
-	                  @SpringBean("appFrameworkService") AppFrameworkService appFrameworkService) {
+					  UiUtils ui,
+					  PageRequest pageRequest,


Did you intentionally change this indention?

dkayiwa · 2018-07-26T15:20:44Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

@@ -110,11 +114,24 @@ public String get(PageModel model,
 			Context.removeProxyPrivilege(GET_LOCATIONS);
 		}

+        model.addAttribute("showSessionLocations", !isLocationUserPropertyAvailable(administrationService));
+		Object showLocation = pageRequest.getAttribute("showSessionLocations");


The indention here does not look right

dkayiwa · 2018-07-26T15:22:20Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

@@ -110,11 +114,24 @@ public String get(PageModel model,
 			Context.removeProxyPrivilege(GET_LOCATIONS);
 		}

+        model.addAttribute("showSessionLocations", !isLocationUserPropertyAvailable(administrationService));


Did you intentionally duplicate the model.addAttribute call?

Nope @dkayiwa, It used to set that value always, and if wanted it will update this value by next line

dkayiwa · 2018-07-26T15:23:38Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

 		model.addAttribute("lastSessionLocation", lastSessionLocation);

 		return null;
 	}

+	private boolean isLocationUserPropertyAvailable(AdministrationService administrationService) {
+		String showLocationSelector = administrationService.getGlobalProperty(ReferenceApplicationConstants.LOCATION_USER_PROPERTY_NAME);


What if it is available but does not have a value of true?

Actually, I decided to use only one GP for this task, So if that GP contains any value except "false", it will return that value as the userProperty name

You have a gp named "referenceapplication.locationUserPropertyName" and then expect a value of true or false? This does not look intuitive because from the look of the gp name, i would expect it to contain the actual name.

We decided to use one GP for this, So when evet it is set, we know that it true, if not set or has value as "false" we know it is false.

What happens when it has a value of a non existing property?

dkayiwa · 2018-07-26T15:26:08Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

@@ -187,7 +204,9 @@ private String getRedirectUrl(PageRequest pageRequest) {
 	public String post(@RequestParam(value = "username", required = false) String username,
 	                   @RequestParam(value = "password", required = false) String password,
 	                   @RequestParam(value = "sessionLocation", required = false) Integer sessionLocationId,
-	                   @SpringBean("locationService") LocationService locationService, UiUtils ui, PageRequest pageRequest,
+	                   @SpringBean("locationService") LocationService locationService,
+					   @SpringBean("adminService") AdministrationService administrationService,


Did you intentionally change the indention?

dkayiwa · 2018-07-26T15:27:12Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

-                                return "redirect:" + redirectUrl;
-                            } else {
-                                if (log.isDebugEnabled())
-                                    log.debug("Redirect contains 'login.', redirecting to home page");


Can we avoid changing the indention such that we only get to see meaningful changes?

Done @dkayiwa

dkayiwa · 2018-07-26T15:28:35Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

@@ -277,7 +316,8 @@ public String post(@RequestParam(value = "username", required = false) String us
 		//TODO limit login attempts by IP Address

 		pageRequest.getSession().setAttribute(SESSION_ATTRIBUTE_REDIRECT_URL, redirectUrl);
-
+		// Since the user is already authenticated without location, need to logout before redirecting
+		Context.logout();


Why would we log out from a method that is supposed to handle log in?

Since I need to do the context.authenticate() before verifying the location restrictions. So if anything required isn't satisfied, then it will be redirected with the authenticated user. So the user should automatically log out from the system before the redirect.

dkayiwa · 2018-07-26T15:29:39Z

omod/src/main/webapp/pages/login.gsp

-			 listItem[i].addEventListener('keyup', function (event){
-				var keyCode = event.which || event.keyCode;
-				switch (keyCode) {
-					case 37: // move left


Too many indention changes. Can we do or fix the indention using another pull request? It gets hard to see what actually changed.

I have done the refactor for those indentions. It occured automatically since I done it through the IntelliJ. Could be better to go through this 😄

Just like i said above

I have updated all the indentions changes

Isn't this another indention?

Extremely sorry @dkayiwa It happened automatically with my IDE. I just made it manually now. Please have a look again

dkayiwa · 2018-07-26T15:44:19Z

We also prefer to attach screenshot on the ticket instead of pull request as per https://wiki.openmrs.org/display/docs/Pull+Request+Tips

dkayiwa · 2018-07-27T11:06:06Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

@@ -110,11 +114,24 @@ public String get(PageModel model,
 			Context.removeProxyPrivilege(GET_LOCATIONS);
 		}

+		model.addAttribute("showSessionLocations", !isLocationUserPropertyAvailable(administrationService));
+		Object showLocation = pageRequest.getAttribute("showSessionLocations");


I still do not understand why you call model.addAttribute twice instead of once

Line 117 - Assign the showSessionLocations from the locationUserproperty
Line 119 - If the URL contains the "showSessionLocations" as the paramerter (while redirecting again to the users who haven't location property) then show the location selector (set model attribute as true) (Ignore what ever in the user location property)

Can't you do it once?

Done @dkayiwa

dkayiwa · 2018-07-27T11:07:00Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

@@ -110,11 +114,24 @@ public String get(PageModel model,
 			Context.removeProxyPrivilege(GET_LOCATIONS);
 		}

+		model.addAttribute("showSessionLocations", !isLocationUserPropertyAvailable(administrationService));
+		Object showLocation = pageRequest.getAttribute("showSessionLocations");
+		if(showLocation != null && showLocation.toString().equals("true")) {


Are you sure we are expecting this value to be true?

Yes, Initial login URL will be "http://localhost:8080/openmrs/login.htm", and then if the user doesn't have the location userproperty, then it will redirect to "http://localhost:8080/openmrs/referenceapplication/login.page?showSessionLocations=true&"

dkayiwa · 2018-07-27T11:07:51Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

 		model.addAttribute("lastSessionLocation", lastSessionLocation);

 		return null;
 	}

+	private boolean isLocationUserPropertyAvailable(AdministrationService administrationService) {
+		String locationUserPropertyName = administrationService.getGlobalProperty(ReferenceApplicationConstants.LOCATION_USER_PROPERTY_NAME);
+		if(StringUtils.isNotBlank(locationUserPropertyName) && !locationUserPropertyName.equals("false")) {


I thought we agreed to simply use a valid user property name. Instead instead of true or false

Yes , Whenever it is set, we know that it is true. If not set, we know it is false.

dkayiwa · 2018-07-27T11:39:52Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

 			}
+		}
+		catch (ContextAuthenticationException ex) {
+			if (log.isDebugEnabled())


Did you take a look at this? https://wiki.openmrs.org/display/docs/Java+Conventions#JavaConventions-CodeStyle

Actually, this came from the existing code. Do you want me to remove this as well?

dkayiwa · 2018-07-27T11:43:39Z

api/src/main/java/org/openmrs/module/referenceapplication/ReferenceApplicationConstants.java

@@ -23,4 +23,6 @@

 	public static final long PROCESS_HL7_TASK_INTERVAL = 5L;

+	public static final String LOCATION_USER_PROPERTY_NAME = "referenceapplication.locationUserPropertyName";


After looking at the other pull request, i have noticed that you expect the user property to be named as locationUuid

In such a case, of what value is this global property?

Using this Global property(name - referenceapplication.locationUserPropertyName), I want to fetch the userProperty Name(should be value of this GP). Then need to use this userPropertyName to fetch the location from the userProperty(should be value of that userProperty).

So in our module, I'm using "locationUuuid" as the userPropertyName to store the locationUuid. So setting "locationUuid" to this GP.

If you know that the property will be named as "locationUuuid", then of what value is the gp?

So can we move the locationUserProperty to a global property name as "locationbasedaccess.locationUserPropertyName"? So the userProperty name also will be fetched from the GP, and use that same value to this RefApp GP as well?

What do you think? What are the pros and cons of either side?

I think, We have already concluded this discussion 😄

dkayiwa · 2018-07-27T14:43:43Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

+		Boolean isLocationUserPropertyAvailable = isLocationUserPropertyAvailable(administrationService);
+		Object showLocation = pageRequest.getAttribute("showSessionLocations");
+		if(showLocation != null && showLocation.toString().equals("true")) {
+			// if the request contains a attribute as showSessionLocations, then ignore isLocationUserPropertyAvailable


Confusing how showLocation is true and then you set is location user property available to false?

if the URL has the parameter as "showSessionLocations" with value True, then we need to ignore the userProperty method(if exist or not). So simply setting isLocationUserPropertyAvailable=false to disable this feature to view the location selector in the login screen. (See the address bar of the browser in the attached images in the PR)

who sets the showSessionLocations parameter to true and when?

When a user doesn't get the location userProperty, then it will redirect to the login page with showSessionLocations=true. So I'm checking this parameter to show/hide the location selector here. See this line - https://github.com/openmrs/openmrs-module-referenceapplication/pull/47/files#diff-bd998e9f6ec90d297ceba7fb14c2fe66R249

dkayiwa · 2018-07-27T14:46:48Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

+				if (Context.isAuthenticated() && Context.getUserContext().getAuthenticatedUser() != null) {
+					String locationUuid = Context.getUserContext().getAuthenticatedUser().getUserProperty(locationUserPropertyName);
+					if (StringUtils.isNotBlank(locationUuid)) {
+						sessionLocation = locationService.getLocationByUuid(locationUuid);


What happens when the uuid is for a non existing location?

It will return the null object to the sessionLocation. So it might cause some issues to the next line.
Just added a fix to this problem. Please look at this line again @dkayiwa

dkayiwa · 2018-07-30T09:17:58Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

+						sessionLocation = locationService.getLocationByUuid(locationUuid);
+					}
+					if (sessionLocation != null) {
+                        sessionLocationId = sessionLocation.getLocationId();


Can you check the indention here?

Fixed @dkayiwa

dkayiwa · 2018-07-30T19:27:43Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

+						sessionLocationId = sessionLocation.getLocationId();
+                    }
+					else {
+					    pageRequest.getSession().setAttribute(ReferenceApplicationWebConstants.SESSION_ATTRIBUTE_ERROR_MESSAGE,


Can you look into the indention here?

dkayiwa · 2018-08-01T19:25:01Z

...c/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

+					if (sessionLocation != null) {
+						sessionLocationId = sessionLocation.getLocationId();
+                    }
+					else {


The formatting or braces around here do not look correct.

… the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen RA-1516 Added support to select the location from the userProperty in the Login Screen Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes Indention changes LBAC-13 Added implementation to create RefApp location glopal property Added changes Added changes Added changes Added changes Added changes Added changes Added changes Added changes Added changes Added changes Added changes Added changes Added changes

dkayiwa reviewed Jul 26, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch from 4501a70 to e7e85c1 Jul 26, 2018

dkayiwa reviewed Jul 26, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch 19 times, most recently from 2c88ce0 to 42ec855 Jul 27, 2018

suthagar23 force-pushed the suthagar23:RA-1516 branch 8 times, most recently from 4475672 to ede8d9a Jul 27, 2018

dkayiwa reviewed Jul 27, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch from ede8d9a to 8755aef Jul 27, 2018

dkayiwa reviewed Jul 27, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch from 8755aef to 677ceb4 Jul 27, 2018

dkayiwa reviewed Jul 27, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch from 677ceb4 to 1a76d98 Jul 27, 2018

dkayiwa reviewed Jul 30, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch from 1a76d98 to 45ea24c Jul 30, 2018

dkayiwa reviewed Jul 30, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch from 45ea24c to 341d0e7 Aug 1, 2018

dkayiwa reviewed Aug 1, 2018

View changes

suthagar23 force-pushed the suthagar23:RA-1516 branch 3 times, most recently from a3965e8 to d3a5ae1 Aug 2, 2018

suthagar23 force-pushed the suthagar23:RA-1516 branch from d3a5ae1 to f1ee7da Aug 2, 2018

dkayiwa merged commit 8d605a5 into openmrs:master Aug 2, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

		@@ -23,4 +23,6 @@

		public static final long PROCESS_HL7_TASK_INTERVAL = 5L;

		public static final String LOCATION_USER_PROPERTY_NAME = "referenceapplication.locationUserPropertyName";

openmrs / openmrs-module-referenceapplication

RA-1516 Added support to select the location from the userProperty in the Login Screen #47

RA-1516 Added support to select the location from the userProperty in the Login Screen #47

Conversation

suthagar23 commented Jul 26, 2018

Description

Ticket

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

suthagar23 Jul 26, 2018 Author Member

This comment has been minimized.

suthagar23 Jul 26, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 26, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

dkayiwa commented Jul 26, 2018

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

This comment has been minimized.

suthagar23 Jul 27, 2018 Author Member

This comment has been minimized.

dkayiwa Jul 27, 2018 Member

dkayiwa Jul 26, 2018
Member

suthagar23 Jul 26, 2018
Author Member

suthagar23 Jul 26, 2018
Author Member

dkayiwa Jul 26, 2018
Member

dkayiwa Jul 26, 2018
Member

dkayiwa Jul 26, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 26, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

dkayiwa Jul 26, 2018
Member

dkayiwa Jul 26, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 26, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 26, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018 •

edited

Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018
Author Member

dkayiwa Jul 27, 2018
Member

suthagar23 Jul 27, 2018 •

edited

Author Member

dkayiwa Jul 30, 2018
Member

suthagar23 Jul 30, 2018
Author Member

dkayiwa Jul 30, 2018
Member

suthagar23 Aug 2, 2018
Author Member

dkayiwa Aug 1, 2018
Member

suthagar23 Aug 2, 2018
Author Member