New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashRouter added to the module instead of BrowserRouter #3

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
2 participants
@sumangala028
Collaborator

sumangala028 commented Jun 18, 2018

Description

Built-in-reports module uses BrowserRouter for the routing. It's fail while refreshing the web page or pressing back button in the browser. It should be fixed with HashRouter to resolve this issue while we are using the React Router V4.

BaseName can be removed if we are using the HashRouter instead of BrowserRouter.

Ticket

https://issues.openmrs.org/browse/BIR-3

@rkorytkowski rkorytkowski merged commit 8585b45 into openmrs:master Jun 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment