Skip to content

Enable Strict Concurrency Checks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Enable Strict Concurrency Checks #4

wants to merge 17 commits into from

Conversation

JosephDuffy
Copy link
Collaborator

@JosephDuffy JosephDuffy commented Jan 24, 2024 •
edited
Loading

The primary change here is to enable strict concurrency checks via -Xfrontend -strict-concurrency=complete the StrictConcurrency experimental featyre. The main knock-on effect of this is that @MainActor has been added to most protocols and types.

I also:

  • Bumped the Swift tools version to 5.9
    • With this the name parameter on the dependency declaration has been deprecated
    • This initially 5.7 but have since moved on to Xocde 15.1
  • Removed support for all but UICollectionViews
    • We don't use any of the other view types so this has no impact on us, other than less to update and maintain
    • We did rely on some of the extensions on UITableView. The PR in the main repo now includes these extensions
  • The required initialisers on ArraySection have been removed
    • I planned to remove these soon because they make it harder to subclass, but these have been removed now because they were used for protocol conformances that cannot be satisfied with an actor-isolated function

@JosephDuffy
Enable strict concurrency checking, support only collection views
57b5f89 
Table view, stack view, and fetched results controller have not been used or tested for a long time so there’s no need to retain them.

Lots of tests are failing but that might be because of changes in iOS; the collection view does not request cells in the same way it did in previous versions.
@JosephDuffy
Fix concurrency warnings
c2886ea
@JosephDuffy
Add first(where:) to ArraySection
0eb2d14
@JosephDuffy
Remove use of deprecated dependency declaration
2588563
@JosephDuffy
Remove redundant @mainactor from functions
fde7604
@JosephDuffy
Fix test compilation on Xcode 14.2
ccf653d
@JosephDuffy
Merge branch 'main' into concurrency
de2188f
@JosephDuffy JosephDuffy marked this pull request as ready for review February 1, 2024 00:51
@JosephDuffy JosephDuffy self-assigned this Feb 1, 2024
@JosephDuffy JosephDuffy removed the request for review from NewWay-opennet March 13, 2024 09:19
@JosephDuffy JosephDuffy requested a review from ngptsporty May 16, 2024 10:55
@JosephDuffy
Merge branch 'main' of github.com:opennetltd/Composed into concurrency
a56ee0d 
# Conflicts:
#	.github/workflows/test.yml
#	Package.swift
#	Sources/ComposedUI/CollectionView/CollectionElement.swift
@JosephDuffy
Fix warning with Swift 6 compiler
a5c7e5c
@JosephDuffy
Test on Xcode 15.1, 15.4, and 16.0
a84947c
@JosephDuffy JosephDuffy mentioned this pull request Feb 3, 2025
Open
@JosephDuffy
Copy link
Collaborator Author

#17 includes these changes.

@JosephDuffy JosephDuffy closed this Feb 4, 2025
@JosephDuffy JosephDuffy deleted the concurrency branch February 4, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KickerChenInOpenNet KickerChenInOpenNet Awaiting requested review from KickerChenInOpenNet

@MarsOpenNet MarsOpenNet Awaiting requested review from MarsOpenNet

@ngptsporty ngptsporty Awaiting requested review from ngptsporty

Assignees

@JosephDuffy JosephDuffy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JosephDuffy