New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "port alread bound" fatal error clearer to the user #50

Closed
billsnow opened this Issue Oct 8, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@billsnow

billsnow commented Oct 8, 2012

Status: In Progress
Project: Flowvisor
Component/s: Core
Affects Version/s: 0.7.2
Fix Version/s: Long Term

Type: Improvement Priority: Major
Reporter: Nick Bastin Assignee: Ali Al-Shabibi
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Description
If you run flowvisor and one of the ports (either OF control or XMLRPC server) is already bound, the error to the user is not very clear:
Starting FlowVisor?
--- Setting logging level to NOTE
respawning too fast -- DYING

Comments
Comment by Nick Bastin [ 10/Sep/11 ]
Really there are a lot of reasons that you can see "respawning too fast – DYING", we should make them all clear to the user rather than just bailing out.

Original issue: https://openflow.stanford.edu/bugs/browse/FLOWVISOR-30

@jbsbbn

This comment has been minimized.

Show comment
Hide comment
@jbsbbn

jbsbbn Oct 23, 2012

I took a look at this in FV 0.8.6, and this error has gotten better, but is still a little vague. /var/log/flowvisor/flowvisor-stderr.log says

--- Setting logging level to NOTE
java.net.BindException: Address already in use
    at sun.nio.ch.Net.bind(Native Method)
    at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:137)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:77)
    at org.flowvisor.ofswitch.OFSwitchAcceptor.<init>(OFSwitchAcceptor.java:37)
    at org.flowvisor.FlowVisor.run(FlowVisor.java:161)
    at org.flowvisor.FlowVisor.main(FlowVisor.java:217)

but doesn't say which address is in use. Could it say, perhaps something more like "Unable to listen on hostname.whatever port 6633 (address/port already in use)" or some such?

jbsbbn commented Oct 23, 2012

I took a look at this in FV 0.8.6, and this error has gotten better, but is still a little vague. /var/log/flowvisor/flowvisor-stderr.log says

--- Setting logging level to NOTE
java.net.BindException: Address already in use
    at sun.nio.ch.Net.bind(Native Method)
    at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:137)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:77)
    at org.flowvisor.ofswitch.OFSwitchAcceptor.<init>(OFSwitchAcceptor.java:37)
    at org.flowvisor.FlowVisor.run(FlowVisor.java:161)
    at org.flowvisor.FlowVisor.main(FlowVisor.java:217)

but doesn't say which address is in use. Could it say, perhaps something more like "Unable to listen on hostname.whatever port 6633 (address/port already in use)" or some such?

@alshabib

This comment has been minimized.

Show comment
Hide comment
@alshabib

alshabib Oct 24, 2012

Member

fixed in nightly.

On Oct 23, 2012, at 6:45 PM, Josh Smift notifications@github.com wrote:

I took a look at this in FV 0.8.6, and this error has gotten better, but is still a little vague. /var/log/flowvisor/flowvisor-stderr.log says

--- Setting logging level to NOTE
java.net.BindException: Address already in use
at sun.nio.ch.Net.bind(Native Method)
at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:137)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:77)
at org.flowvisor.ofswitch.OFSwitchAcceptor.(OFSwitchAcceptor.java:37)
at org.flowvisor.FlowVisor.run(FlowVisor.java:161)
at org.flowvisor.FlowVisor.main(FlowVisor.java:217)

but doesn't say which address is in use. Could it say, perhaps something more like "Unable to listen on hostname.whatever port 6633 (address/port already in use)" or some such?


Reply to this email directly or view it on GitHub.

Member

alshabib commented Oct 24, 2012

fixed in nightly.

On Oct 23, 2012, at 6:45 PM, Josh Smift notifications@github.com wrote:

I took a look at this in FV 0.8.6, and this error has gotten better, but is still a little vague. /var/log/flowvisor/flowvisor-stderr.log says

--- Setting logging level to NOTE
java.net.BindException: Address already in use
at sun.nio.ch.Net.bind(Native Method)
at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:137)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:77)
at org.flowvisor.ofswitch.OFSwitchAcceptor.(OFSwitchAcceptor.java:37)
at org.flowvisor.FlowVisor.run(FlowVisor.java:161)
at org.flowvisor.FlowVisor.main(FlowVisor.java:217)

but doesn't say which address is in use. Could it say, perhaps something more like "Unable to listen on hostname.whatever port 6633 (address/port already in use)" or some such?


Reply to this email directly or view it on GitHub.

@ghost ghost assigned alshabib Nov 27, 2012

@alshabib alshabib closed this Dec 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment