From 2f39b54fd59bb1bb711af277f7cd408206a3b6d5 Mon Sep 17 00:00:00 2001 From: Yuta HIGUCHI Date: Wed, 18 Jan 2017 20:09:17 -0800 Subject: [PATCH] Fix shellcheck detected errors - onos-package SC2071: > is for string comparisons. Use -gt instead. - ./tools/build/onos-blackduck-zip SC1035: You need a space after the [ and before the ]. Change-Id: I409b4a181e9cd49795afbdaa68b68c26413b9401 --- tools/build/onos-blackduck-zip | 4 ++-- tools/build/onos-package | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/build/onos-blackduck-zip b/tools/build/onos-blackduck-zip index 5b0e8b76c1f..876046023c2 100755 --- a/tools/build/onos-blackduck-zip +++ b/tools/build/onos-blackduck-zip @@ -39,7 +39,7 @@ check_copy() { [ -d "$FOLDER" ] && rm -r $FOLDER mkdir $FOLDER mvn clean install - if [$? -eq 0 ]; then + if [ $? -eq 0 ]; then cp -r -a * $FOLDER; if [ -d "$FOLDER/.git" ]; then rm -r $FOLDER/.git @@ -65,4 +65,4 @@ cd .. rm -r $FOLDER cd $ONOS_ROOT -git checkout $CURRENT_TAG \ No newline at end of file +git checkout $CURRENT_TAG diff --git a/tools/build/onos-package b/tools/build/onos-package index 1700b3c1af5..18619da8576 100755 --- a/tools/build/onos-package +++ b/tools/build/onos-package @@ -204,7 +204,7 @@ function build_rpm() { set -e [[ $# == 0 ]] && ONOS_PACKAGE_TAR_arg=true -while [[ $# > 0 ]]; do +while [[ $# -gt 0 ]]; do case $1 in -t|--tar) ONOS_PACKAGE_TAR_arg=true