fix(e2e): Use button instead of checkbox in parallel test #1034
+19
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vicb
reviewed
Nov 10, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Could you please add details to the description
why, how this was tested, ...
Thanks!
This reverts commit a334ff2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading through playwright issues there seems to be multiple reported issues with checkboxes and its click API that looks similar to ours. With this PR we refactor
parallel.test.tsto use buttons for managing the state.I first deployed the
/examplesapps and ran the E2E onmainright now. That seemed to flake onparallel.test.ts.I then went ahead to deploy with this PR, and now the E2E seems to pass 100%.
I also reverted this PR as it didn't seem to work as we hoped.