From 1036b049d33a20b7fc5c4bfe15a7b791efaa9336 Mon Sep 17 00:00:00 2001 From: magnus Date: Mon, 10 Nov 2025 12:57:16 +0100 Subject: [PATCH 1/2] fix(e2e): Use button instead of checkbox in parallel test --- .../app-pages-router/app/parallel/layout.tsx | 30 +++++-------------- examples/app-router/app/parallel/layout.tsx | 30 +++++-------------- .../tests/appPagesRouter/parallel.test.ts | 6 ++-- .../tests/appRouter/parallel.test.ts | 4 +-- 4 files changed, 19 insertions(+), 51 deletions(-) diff --git a/examples/app-pages-router/app/parallel/layout.tsx b/examples/app-pages-router/app/parallel/layout.tsx index 56fe9a7d9..3bf43f4bd 100644 --- a/examples/app-pages-router/app/parallel/layout.tsx +++ b/examples/app-pages-router/app/parallel/layout.tsx @@ -17,29 +17,13 @@ export default function Layout({ return (
-
- - +
+ +
{routeA && a} diff --git a/examples/app-router/app/parallel/layout.tsx b/examples/app-router/app/parallel/layout.tsx index 56fe9a7d9..3bf43f4bd 100644 --- a/examples/app-router/app/parallel/layout.tsx +++ b/examples/app-router/app/parallel/layout.tsx @@ -17,29 +17,13 @@ export default function Layout({ return (
-
- - +
+ +
{routeA && a} diff --git a/packages/tests-e2e/tests/appPagesRouter/parallel.test.ts b/packages/tests-e2e/tests/appPagesRouter/parallel.test.ts index 8f3bf80f8..663cb7989 100644 --- a/packages/tests-e2e/tests/appPagesRouter/parallel.test.ts +++ b/packages/tests-e2e/tests/appPagesRouter/parallel.test.ts @@ -2,7 +2,7 @@ import { expect, test } from "@playwright/test"; test("Parallel routes", async ({ page }) => { await page.goto("/"); - await page.locator('[href="/parallel"]').click(); + await page.getByRole("link", { name: "Parallel" }).click(); await page.waitForURL("/parallel"); @@ -13,13 +13,13 @@ test("Parallel routes", async ({ page }) => { await expect(routeB).not.toBeVisible(); // Enable A, which should be visible but not B - await page.locator('input[name="a"]').check(); + await page.getByTestId("enable-a").click(); routeA = page.getByText("Parallel Route A"); await expect(routeA).toBeVisible(); await expect(routeB).not.toBeVisible(); // Enable B, both should be visible - await page.locator('input[name="b"]').check(); + await page.getByTestId("enable-b").click(); routeB = page.getByText("Parallel Route B"); await expect(routeA).toBeVisible(); await expect(routeB).toBeVisible(); diff --git a/packages/tests-e2e/tests/appRouter/parallel.test.ts b/packages/tests-e2e/tests/appRouter/parallel.test.ts index bbf9c9d35..663cb7989 100644 --- a/packages/tests-e2e/tests/appRouter/parallel.test.ts +++ b/packages/tests-e2e/tests/appRouter/parallel.test.ts @@ -13,13 +13,13 @@ test("Parallel routes", async ({ page }) => { await expect(routeB).not.toBeVisible(); // Enable A, which should be visible but not B - await page.locator('input[name="a"]').check(); + await page.getByTestId("enable-a").click(); routeA = page.getByText("Parallel Route A"); await expect(routeA).toBeVisible(); await expect(routeB).not.toBeVisible(); // Enable B, both should be visible - await page.locator('input[name="b"]').check(); + await page.getByTestId("enable-b").click(); routeB = page.getByText("Parallel Route B"); await expect(routeA).toBeVisible(); await expect(routeB).toBeVisible(); From 9a06acd4e8325884e971ee43baae614dc3c05327 Mon Sep 17 00:00:00 2001 From: magnus Date: Mon, 10 Nov 2025 19:39:07 +0100 Subject: [PATCH 2/2] Revert "fix(e2e): Workaround for parallel.test.ts (#1031)" This reverts commit a334ff2eadcaf6d7ec2f1ca80c7ce748abe71c37. --- packages/tests-e2e/playwright.config.js | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/packages/tests-e2e/playwright.config.js b/packages/tests-e2e/playwright.config.js index 884f5e2b1..097102242 100644 --- a/packages/tests-e2e/playwright.config.js +++ b/packages/tests-e2e/playwright.config.js @@ -31,14 +31,4 @@ export default defineConfig({ }, }, ], - // Workaround for https://github.com/microsoft/playwright/issues/36371 - // It seems to be failing in our Github action - // https://github.com/opennextjs/opennextjs-aws/actions/runs/19116336570/job/54627469525#step:15:171 - use: { - launchOptions: { - args: [ - "--disable-features=AcceptCHFrame,AutoExpandDetailsElement,AvoidUnnecessaryBeforeUnloadCheckSync,CertificateTransparencyComponentUpdater,DestroyProfileOnBrowserClose,DialMediaRouteProvider,ExtensionManifestV2Disabled,GlobalMediaControls,HttpsUpgrades,ImprovedCookieControls,LazyFrameLoading,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,DeferRendererTasksAfterInput", - ], - }, - }, });