From 353f51b3380b17d91a0c8caa406ae5e94f70f16b Mon Sep 17 00:00:00 2001 From: Magnus Dahl Eide Date: Sun, 31 Aug 2025 11:21:37 +0200 Subject: [PATCH 1/2] chore(e2e): Skip request.url is host when ran locally --- packages/tests-e2e/tests/appPagesRouter/host.test.ts | 6 ++++++ packages/tests-e2e/tests/appRouter/host.test.ts | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/packages/tests-e2e/tests/appPagesRouter/host.test.ts b/packages/tests-e2e/tests/appPagesRouter/host.test.ts index 98141106c..d2f5eab75 100644 --- a/packages/tests-e2e/tests/appPagesRouter/host.test.ts +++ b/packages/tests-e2e/tests/appPagesRouter/host.test.ts @@ -4,6 +4,12 @@ import { expect, test } from "@playwright/test"; * Tests that the request.url is the deployed host and not localhost */ test("Request.url is host", async ({ baseURL, page }) => { + // We skip this test when E2E is run locally with `http` as protocol. + // The cause can be seen here: https://github.com/opennextjs/opennextjs-aws/issues/969#issuecomment-3239569901 + test.skip( + (baseURL ?? "").includes("http://localhost"), + "Skipping test on localhost", + ); await page.goto("/api/host"); const el = page.getByText(`{"url":"${baseURL}/api/host"}`); diff --git a/packages/tests-e2e/tests/appRouter/host.test.ts b/packages/tests-e2e/tests/appRouter/host.test.ts index 98141106c..d2f5eab75 100644 --- a/packages/tests-e2e/tests/appRouter/host.test.ts +++ b/packages/tests-e2e/tests/appRouter/host.test.ts @@ -4,6 +4,12 @@ import { expect, test } from "@playwright/test"; * Tests that the request.url is the deployed host and not localhost */ test("Request.url is host", async ({ baseURL, page }) => { + // We skip this test when E2E is run locally with `http` as protocol. + // The cause can be seen here: https://github.com/opennextjs/opennextjs-aws/issues/969#issuecomment-3239569901 + test.skip( + (baseURL ?? "").includes("http://localhost"), + "Skipping test on localhost", + ); await page.goto("/api/host"); const el = page.getByText(`{"url":"${baseURL}/api/host"}`); From 47ccdc14c94778b87a683e2b57d190a7d243c595 Mon Sep 17 00:00:00 2001 From: Magnus Dahl Eide Date: Sun, 31 Aug 2025 11:43:16 +0200 Subject: [PATCH 2/2] refactor --- packages/tests-e2e/tests/appPagesRouter/host.test.ts | 2 +- packages/tests-e2e/tests/appRouter/host.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/tests-e2e/tests/appPagesRouter/host.test.ts b/packages/tests-e2e/tests/appPagesRouter/host.test.ts index d2f5eab75..d2dd1729e 100644 --- a/packages/tests-e2e/tests/appPagesRouter/host.test.ts +++ b/packages/tests-e2e/tests/appPagesRouter/host.test.ts @@ -7,7 +7,7 @@ test("Request.url is host", async ({ baseURL, page }) => { // We skip this test when E2E is run locally with `http` as protocol. // The cause can be seen here: https://github.com/opennextjs/opennextjs-aws/issues/969#issuecomment-3239569901 test.skip( - (baseURL ?? "").includes("http://localhost"), + (baseURL ?? "").startsWith("http://localhost"), "Skipping test on localhost", ); await page.goto("/api/host"); diff --git a/packages/tests-e2e/tests/appRouter/host.test.ts b/packages/tests-e2e/tests/appRouter/host.test.ts index d2f5eab75..d2dd1729e 100644 --- a/packages/tests-e2e/tests/appRouter/host.test.ts +++ b/packages/tests-e2e/tests/appRouter/host.test.ts @@ -7,7 +7,7 @@ test("Request.url is host", async ({ baseURL, page }) => { // We skip this test when E2E is run locally with `http` as protocol. // The cause can be seen here: https://github.com/opennextjs/opennextjs-aws/issues/969#issuecomment-3239569901 test.skip( - (baseURL ?? "").includes("http://localhost"), + (baseURL ?? "").startsWith("http://localhost"), "Skipping test on localhost", ); await page.goto("/api/host");