From c4185c3aff22909ae50479186fb44002d6a7ddea Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Wed, 2 Oct 2024 12:10:28 +0100 Subject: [PATCH 1/2] specify inspector port to playwright preview:worker commands to avoid flakiness in e2es --- examples/api/e2e/playwright.config.ts | 2 +- examples/create-next-app/e2e/playwright.config.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/api/e2e/playwright.config.ts b/examples/api/e2e/playwright.config.ts index 4bca883e..fc17459e 100644 --- a/examples/api/e2e/playwright.config.ts +++ b/examples/api/e2e/playwright.config.ts @@ -46,7 +46,7 @@ export default defineConfig({ /* Run your local dev server before starting the tests */ webServer: { - command: "pnpm preview:worker", + command: "pnpm preview:worker --inspector-port 9330", url: "http://localhost:8770", reuseExistingServer: !process.env.CI, }, diff --git a/examples/create-next-app/e2e/playwright.config.ts b/examples/create-next-app/e2e/playwright.config.ts index 6aad04dd..881fdcfb 100644 --- a/examples/create-next-app/e2e/playwright.config.ts +++ b/examples/create-next-app/e2e/playwright.config.ts @@ -46,7 +46,7 @@ export default defineConfig({ /* Run your local dev server before starting the tests */ webServer: { - command: "pnpm preview:worker", + command: "pnpm preview:worker --inspector-port 9331", url: "http://localhost:8771", reuseExistingServer: !process.env.CI, }, From 57470d0c6f180d13e0cc4ac06014889b7f59b4a6 Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Mon, 7 Oct 2024 11:44:27 +0100 Subject: [PATCH 2/2] fixup! specify inspector port to playwright preview:worker commands to avoid flakiness in e2es move inspector port setting to package.json files --- examples/api/e2e/playwright.config.ts | 2 +- examples/api/package.json | 2 +- examples/create-next-app/e2e/playwright.config.ts | 2 +- examples/create-next-app/package.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/api/e2e/playwright.config.ts b/examples/api/e2e/playwright.config.ts index fc17459e..4bca883e 100644 --- a/examples/api/e2e/playwright.config.ts +++ b/examples/api/e2e/playwright.config.ts @@ -46,7 +46,7 @@ export default defineConfig({ /* Run your local dev server before starting the tests */ webServer: { - command: "pnpm preview:worker --inspector-port 9330", + command: "pnpm preview:worker", url: "http://localhost:8770", reuseExistingServer: !process.env.CI, }, diff --git a/examples/api/package.json b/examples/api/package.json index 5671a7cc..d6846e8d 100644 --- a/examples/api/package.json +++ b/examples/api/package.json @@ -8,7 +8,7 @@ "start": "next start", "lint": "next lint", "build:worker": "pnpm cloudflare", - "dev:worker": "wrangler dev --port 8770", + "dev:worker": "wrangler dev --port 8770 --inspector-port 9330", "preview:worker": "pnpm build:worker && pnpm dev:worker", "e2e": "playwright test -c e2e/playwright.config.ts", "e2e:dev": "playwright test -c e2e/playwright.dev.config.ts", diff --git a/examples/create-next-app/e2e/playwright.config.ts b/examples/create-next-app/e2e/playwright.config.ts index 881fdcfb..6aad04dd 100644 --- a/examples/create-next-app/e2e/playwright.config.ts +++ b/examples/create-next-app/e2e/playwright.config.ts @@ -46,7 +46,7 @@ export default defineConfig({ /* Run your local dev server before starting the tests */ webServer: { - command: "pnpm preview:worker --inspector-port 9331", + command: "pnpm preview:worker", url: "http://localhost:8771", reuseExistingServer: !process.env.CI, }, diff --git a/examples/create-next-app/package.json b/examples/create-next-app/package.json index bf798661..1e933f5e 100644 --- a/examples/create-next-app/package.json +++ b/examples/create-next-app/package.json @@ -8,7 +8,7 @@ "start": "next start", "lint": "next lint", "build:worker": "cloudflare", - "dev:worker": "wrangler dev --port 8771", + "dev:worker": "wrangler dev --port 8771 --inspector-port 9331", "preview:worker": "pnpm build:worker && pnpm dev:worker", "e2e": "playwright test -c e2e/playwright.config.ts" },