From aa1b3b678cf7a7a756a0e5a3445c8c516bd3f11f Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Wed, 26 Nov 2025 11:33:45 -0500 Subject: [PATCH 1/2] fix: de-duplicate blob operation spans --- src/run/storage/storage.cts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/run/storage/storage.cts b/src/run/storage/storage.cts index e16fbe383a..4f4a6b0594 100644 --- a/src/run/storage/storage.cts +++ b/src/run/storage/storage.cts @@ -43,6 +43,7 @@ export const getMemoizedKeyValueStoreBackedByRegionalBlobStore = ( const result = await store.getWithMetadata(blobKey, { type: 'json', etag: previousEtag, + span, }) const shouldReuseMemoizedBlob = result?.etag && previousEtag === result?.etag @@ -80,7 +81,7 @@ export const getMemoizedKeyValueStoreBackedByRegionalBlobStore = ( const blobKey = await encodeBlobKey(key) return withActiveSpan(tracer, otelSpanTitle, async (span) => { span?.setAttributes({ key, blobKey }) - const writeResult = await store.setJSON(blobKey, value) + const writeResult = await store.setJSON(blobKey, value, { span }) if (writeResult?.etag) { inMemoryCache.set(key, { data: value, From 2a01efd36b09a9e208614743a18c7f5c2c3b3957 Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Wed, 26 Nov 2025 13:19:04 -0500 Subject: [PATCH 2/2] fix: clean up redundant attributes --- src/run/storage/storage.cts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/run/storage/storage.cts b/src/run/storage/storage.cts index 4f4a6b0594..2cfa2f760e 100644 --- a/src/run/storage/storage.cts +++ b/src/run/storage/storage.cts @@ -38,7 +38,7 @@ export const getMemoizedKeyValueStoreBackedByRegionalBlobStore = ( ? memoizedValue : {} - span?.setAttributes({ key, blobKey, previousEtag }) + span?.setAttributes({ key }) const result = await store.getWithMetadata(blobKey, { type: 'json', @@ -62,12 +62,6 @@ export const getMemoizedKeyValueStoreBackedByRegionalBlobStore = ( inMemoryCache.set(key, blob) } - span?.setAttributes({ - etag: result?.etag, - reusingPreviouslyFetchedBlob: shouldReuseMemoizedBlob, - status: blob ? (shouldReuseMemoizedBlob ? 'Hit, no change' : 'Hit') : 'Miss', - }) - return blob }) inMemoryCache.set(key, getPromise)