-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional edges to show direct/ultimate ownership #5
Comments
I'm not certain this will always be the case. You might also end up with a mix of direct and indirect relationships when combining data from multiple sources. We discussed that this kind of 'link line' could potentially exist between any two points in a chain on the directed graph. My sense is that the programatic trigger for showing it in the style above would be when the bundle of statements contains:
We discussed the idea that an |
@timgdavies - thanks for the clarification, I'd forgotten that part of the discussion. However, I think for the purposes of this experiment we should start with the simple case where the data explicitly declares the relationship and worry about other ways we can infer similar things later. I'd like to get the rendering aspect worked out first before we get bogged down in data mapping/graph traversal issues. Obviously if those are easy, we can add new tickets to expand the scope. |
At present if we provide edge data to Dagre to render automatically then this kind of relationship is drawn poorly (see image). It is possible we could add relationships manually with D3 after the render. For example adding an arc between two nodes positioned behind whatever else is already rendered. |
We decided in our mid-sprint review call to park any future work on this feature, except for one small technical foundation which I've ticketed as #10. We'll review later whether to explore this further, potentially exploring the options of:
As a result, I'm going to leave this ticket open, but remove it from the scope of the project for this sprint. |
Just wanted to note that we've got an example now from the Armenian ZCMC declaration where the indirect ooc interests between BOs and the declaring entity are disclosed as are the component intermediaries. This results in lots of solid lines: no differentiation between the actual direct relationships and the 'summary' indirect relationship. It's a good test case. |
The edge rendering and visualisation of indirect relationships has moved on since this ticket was opened. (For example, relationship edges marked as 'indirect' are now dotted - not solid - lines. And the layout of edges is better.)
Development of the BODS visualiser is focusing on explicitly declared information in the data, rather than making and visualising inferences. @StephenAbbott - I suggest we close this ticket as out-of-date. If anyone wants to suggest a new feature relating to inferred relationships, starting a new ticket would be best. |
In the following image, the grey dashed line is an example of a concept for distinguishing between direct and indirect ownership:
The grey line shows who the ultimate owner is and is annotated with a calculated percentage showing their eventual share ownership. (For the purposes of this ticket, ignore the other details in the image.) Technically, this would be driven by the
isComponent
andcomponentStatementIDs
fields in the data standard.For the purposes of this experiment, we can assume that calculating the percentage ownership is out of scope. We solely want to understand if it's possible to display these additional edges in a way that is understandable. Especially in a way that works in more complex graphs (i.e. Kwik Fit https://register.openownership.org/entities/59b9197d67e4ebf340d33ddc/graph).
The text was updated successfully, but these errors were encountered: