Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipynb CSS style in RTD Sphinx theme #748

Merged
merged 2 commits into from Feb 3, 2018

Conversation

Projects
None yet
2 participants
@jhprinz
Copy link
Contributor

commented Jan 1, 2018

This just fixes the use of some CSS. It has always been there but was not used. This add the correct file and uses it.

jhprinz added some commits Jan 1, 2018

@dwhswenson dwhswenson added the misc PR label Jan 10, 2018

@dwhswenson

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

All of this looks good to me. I'd been holding off on reviewing this until I figured out how to fix the problem that I fixed in #749. Since that might also be a problem here (problems correctly uploading CSS files), I recommend merging this after #749. Otherwise, looks ready to merge.

Side note: We might consider switching to nbsphinx for adding notebooks to sphinx docs. I've been using this in my contact maps package, and it works reasonably well. It has support for making PDFs, which is nice, and we don't have to maintain it. I'll make a separate issue with the pros and cons of that sometime soon.

@dwhswenson

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

The build after merging #749 passed (https://travis-ci.org/openpathsampling/openpathsampling/builds/336904078), so merging this!

@dwhswenson dwhswenson merged commit d2708b3 into openpathsampling:master Feb 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 77.936%
Details

@dwhswenson dwhswenson referenced this pull request Feb 25, 2018

Merged

Release 0.9.4 #761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.