Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs deployment updates #749

Merged
merged 7 commits into from Feb 3, 2018

Conversation

Projects
None yet
2 participants
@dwhswenson
Copy link
Member

commented Jan 10, 2018

We were having some problems with the OPS website. For some reason, the S3 upload was incorrectly identifying MIME types, meaning that even though our CSS was being uploaded, it wasn't actually being used as CSS on the website. (This was not an easy thing to debug!)

In this PR, I mainly changed some of the structure of how the push-docs-to-s3.py script works. It could do with more cleanup, but this is all to enable quick fixes if something goes wrong with the S3 upload process in the future. The website is already fixed, because I could force the upload from the docs_deploy branch, where I did this work.

dwhswenson added some commits Jan 9, 2018

Stop docs_deploy from actually deploying
(easy to switch this or to have other behavior for docs_deploy)
@dwhswenson

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2018

oops... forgot to ask @jhprinz to review this -- anyway, this has been ready for review ever since I opened the PR.

if [[ "$TRAVIS_BRANCH" == "master" ]]; then
python devtools/ci/push-docs-to-s3.py
elif [[ "$TRAVIS_BRANCH" == "docs_deploy" ]]; then
# change the behavior for the docs testing branch (docs_deploy branch in

This comment has been minimized.

Copy link
@jhprinz

jhprinz Feb 3, 2018

Contributor

interesting idea to have a branch for docs...

This comment has been minimized.

Copy link
@dwhswenson

dwhswenson Feb 3, 2018

Author Member

yeah, that brach has actually been around for a while to test deployment behavior, since PRs from my own fork don't get the AWS keys.

This comment has been minimized.

Copy link
@jhprinz

jhprinz Feb 3, 2018

Contributor

but you disabled this now, correct?

This comment has been minimized.

Copy link
@dwhswenson

dwhswenson Feb 3, 2018

Author Member

oh, right now it behaves the same as a fork PR. But the trick is that to make that deploy (if testing why normal deployment fails), all you have to do is switch out which line is commented there. It specifically has the (commented out, but ready to use) --clobber option which will overwrite (instead of sync diffs). I figure that's probably what you want if you're in that situation ;-)

@jhprinz

jhprinz approved these changes Feb 3, 2018

@jhprinz

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2018

Merging...

@jhprinz jhprinz merged commit a5bf327 into master Feb 3, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 77.936%
Details

@dwhswenson dwhswenson referenced this pull request Feb 25, 2018

Merged

Release 0.9.4 #761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.