Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Explicit algorithm parameter in openpgp.generateKey #1179

Merged
merged 4 commits into from Jan 4, 2021

Conversation

@larabr
Copy link
Contributor

@larabr larabr commented Nov 14, 2020

  • Changes openpgp.generateKey to accept an explicit type parameter, instead of inferring its value from the curve or rsaBits params
  • Introduces config.minRsaBits to set minimum key size of RSA key generation
src/key/key.js Outdated Show resolved Hide resolved
Loading
src/key/key.js Outdated Show resolved Hide resolved
Loading
src/key/helper.js Outdated Show resolved Hide resolved
Loading
src/key/helper.js Outdated Show resolved Hide resolved
Loading
test/general/key.js Outdated Show resolved Hide resolved
Loading
test/general/key.js Outdated Show resolved Hide resolved
Loading
test/general/key.js Outdated Show resolved Hide resolved
Loading
@larabr larabr force-pushed the algo-key-generation branch 2 times, most recently from 403bad7 to a54c160 Nov 19, 2020
@larabr larabr marked this pull request as ready for review Nov 19, 2020
.gitignore Outdated Show resolved Hide resolved
Loading
src/key/factory.js Outdated Show resolved Hide resolved
Loading
src/key/factory.js Outdated Show resolved Hide resolved
Loading
src/key/helper.js Outdated Show resolved Hide resolved
Loading
src/key/key.js Outdated Show resolved Hide resolved
Loading
src/key/key.js Outdated Show resolved Hide resolved
Loading
src/openpgp.js Outdated Show resolved Hide resolved
Loading
src/openpgp.js Outdated Show resolved Hide resolved
Loading
src/openpgp.js Outdated Show resolved Hide resolved
Loading
src/config/config.js Outdated Show resolved Hide resolved
Loading
src/config/config.js Outdated Show resolved Hide resolved
Loading
src/key/factory.js Outdated Show resolved Hide resolved
Loading
src/key/helper.js Outdated Show resolved Hide resolved
Loading
@larabr larabr force-pushed the algo-key-generation branch 2 times, most recently from d91b197 to 351e673 Dec 9, 2020
src/key/key.js Show resolved Hide resolved
Loading
test/general/key.js Outdated Show resolved Hide resolved
Loading
.gitignore Outdated Show resolved Hide resolved
Loading
@larabr larabr force-pushed the algo-key-generation branch 2 times, most recently from 78408e6 to 84a2797 Dec 17, 2020
@larabr larabr force-pushed the algo-key-generation branch from 84a2797 to c67a159 Dec 22, 2020
@larabr larabr force-pushed the algo-key-generation branch from c67a159 to d1605b0 Dec 22, 2020
@twiss twiss merged commit 3c41bcf into openpgpjs:v5 Jan 4, 2021
1 check passed
Loading
larabr added a commit that referenced this issue Jan 13, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter,
  instead of inferring its value from the `curve` or `rsaBits` params
- Introduces `config.minRsaBits` to set minimum key size of RSA key generation
larabr added a commit that referenced this issue Jan 13, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter,
  instead of inferring its value from the `curve` or `rsaBits` params
- Introduces `config.minRsaBits` to set minimum key size of RSA key generation
twiss added a commit that referenced this issue Jan 20, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter,
  instead of inferring its value from the `curve` or `rsaBits` params
- Introduces `config.minRsaBits` to set minimum key size of RSA key generation
twiss added a commit that referenced this issue Jan 24, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter,
  instead of inferring its value from the `curve` or `rsaBits` params
- Introduces `config.minRsaBits` to set minimum key size of RSA key generation
twiss added a commit that referenced this issue Feb 9, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter,
  instead of inferring its value from the `curve` or `rsaBits` params
- Introduces `config.minRsaBits` to set minimum key size of RSA key generation
@larabr larabr deleted the algo-key-generation branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants