Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding subkeys that use blacklisted curves #1423

Merged
merged 1 commit into from Dec 1, 2021

Conversation

larabr
Copy link
Collaborator

@larabr larabr commented Oct 19, 2021

Breaking change:
when generating new subkeys through key.addSubkey(), we now check config.rejectCurves and prevent adding subkeys using the corresponding curves.
By default, config.rejectCurves includes the brainpool curves (brainpoolP256r1, brainpoolP384r1, brainpoolP512r1) and the Bitcoin curve (secp256k1).

This is a follow up to #1395 , which introduced the same check to openpgp.generateKey.

twiss
twiss approved these changes Oct 21, 2021
@larabr larabr added this to the v5.1 milestone Oct 25, 2021
@larabr larabr merged commit 6fc005f into openpgpjs:main Dec 1, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants