Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAPI accepts a single public key or an array #232
Merged
Conversation
misjoinder
changed the title
amiraliakbari
commented
Jun 9, 2014
|
+1 |
|
Sorry for the late response. This looks good. @msjoinder can you adapt the documentation above the function declaration for your change. Then I'll go ahead and merge it for the v0.6.2 release. Thanks. |
|
I made another commit to add a single key object to the docs. Let me know what could be phrased better or if there are additional docs to update |
|
Thanks. Looks good. I'll merge and release 0.6.2 |
tanx
pushed a commit
that referenced
this pull request
Jun 28, 2014
API accepts a single public key or an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
misjoinder commentedJun 7, 2014
Changes the API to allow a single public key object to be sent, instead of as a one-element array.
Where currently you must send
encryptMessage([PublicKey],PlainText)you can also sendencryptMessage(PublicKey,PlainText).An array of public keys can still be sent, but this clears up a confusing requirement responsible for developer errors (see #189 and #194)