Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API accepts a single public key or an array #232

Merged
merged 4 commits into from Jun 28, 2014

Conversation

@misjoinder
Copy link
Contributor

misjoinder commented Jun 7, 2014

Changes the API to allow a single public key object to be sent, instead of as a one-element array.

Where currently you must send encryptMessage([PublicKey],PlainText) you can also send encryptMessage(PublicKey,PlainText).

An array of public keys can still be sent, but this clears up a confusing requirement responsible for developer errors (see #189 and #194)

@misjoinder misjoinder changed the title API accepts a public key string or an array API accepts a single public key or an array Jun 7, 2014
@amiraliakbari
Copy link

amiraliakbari commented Jun 9, 2014

+1

@tanx
Copy link
Member

tanx commented Jun 13, 2014

Sorry for the late response. This looks good.

@msjoinder can you adapt the documentation above the function declaration for your change. Then I'll go ahead and merge it for the v0.6.2 release. Thanks.

@misjoinder
Copy link
Contributor Author

misjoinder commented Jun 22, 2014

I made another commit to add a single key object to the docs. Let me know what could be phrased better or if there are additional docs to update

@tanx
Copy link
Member

tanx commented Jun 28, 2014

Thanks. Looks good. I'll merge and release 0.6.2

@tanx tanx closed this Jun 28, 2014
@tanx tanx reopened this Jun 28, 2014
tanx pushed a commit that referenced this pull request Jun 28, 2014
API accepts a single public key or an array
@tanx tanx merged commit 68a5739 into openpgpjs:master Jun 28, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.