Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression support for the high-level API #513

Closed
wants to merge 6 commits into from
Closed

Compression support for the high-level API #513

wants to merge 6 commits into from

Conversation

barhun
Copy link

@barhun barhun commented Jan 17, 2017

This PR adds compression support to the high-level encrypt function. The feature was what I needed today, and I thought others might find it useful because some people had also been requesting compression for outgoing messages as mentioned in pull request #272.

By default, the encrypt function still generates uncompressed messages; so the new API maintains backwards compatibility with this new feature added. However, if it comes better to enable compression with no extra parameters as suggested in issue #87; the compress property of the parameter object can be made optional with a default value set to true. I am still not sure whether it was the right way to go but the algorithm to use is taken from the value of openpgp.config.compression. Do you think this is good or it would make a better way to allow parameter passing to override the configuration value for another compression algorithm?

Note: bzip2 is yet to be implemented by low-level objects. zip and zlib appear to be working as expected with decent performance overhead.

@barhun
Copy link
Author

barhun commented Jan 17, 2017

There are some integration errors that cause browser tests to fail. Could you please check them?

Replace template strings with string concatenations

Replace lambda expressions with anon. functions

Added compression support to the high-level api
@mmso mmso mentioned this pull request Feb 13, 2018
@bartbutler
Copy link
Member

Thanks, finally got this feature merged in the mainline branch, sorry it took so long!

@bartbutler bartbutler closed this Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants