Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configury: Allow to override build date+host+user #1560

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Dec 6, 2019

Allow to override build date+host+user with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Also switch to UTC to be independent of timezone.
Also use ISO 8601 date format to be easier to parse.

Note: This date call is designed to work with different flavors
of date (GNU, BSD and others).
If only GNU (Linux) support is needed, the patch can be simplified.

This PR was done while working on reproducible builds for openSUSE.

For reproducible builds, it would also be a good solution to just drop one or both of these date+user+host to avoid the added complexity.

with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Also switch to UTC to be independent of timezone.
Also use ISO 8601 date format to be easier to parse.

Note: This date call is designed to work with different flavors
of date (GNU, BSD and others).
If only GNU (Linux) support is needed, the patch can be simplified.

This PR was done while working on reproducible builds for openSUSE.

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
@bmwiedemann bmwiedemann force-pushed the bmwiedemann:date branch from 9dc198f to d028c66 Dec 6, 2019
@rhc54

This comment has been minimized.

Copy link
Contributor

rhc54 commented Dec 6, 2019

Thanks!

@rhc54 rhc54 merged commit 3999206 into openpmix:master Dec 6, 2019
11 checks passed
11 checks passed
mlnx
Details
Commit email checker Good email address. Yay!
IBM CI (Cross-version) All Tests Passed!
Details
IBM CI (Cross-version: Tool) All Tests Passed!
Details
IBM CI (Cross-version: make check) All Tests Passed!
Details
IBM CI (GNU Compiler) All Tests Passed!
Details
IBM CI (PGI Compiler) All Tests Passed!
Details
IBM CI (XL Compiler) All Tests Passed!
Details
Signed-off-by checker Commit is signed off. Yay!
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jjhursey

This comment has been minimized.

Copy link
Member

jjhursey commented Dec 6, 2019

This should be PR'ed to the v3.1 branch. We can get it in the pipeline for v3.1.5

@jjhursey

This comment has been minimized.

Copy link
Member

jjhursey commented Dec 6, 2019

Ah Ralph beat me to it :) PR #1561

@bmwiedemann bmwiedemann deleted the bmwiedemann:date branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.