Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you handle time? #54

Open
huwd opened this issue Feb 7, 2020 · 1 comment
Open

How do you handle time? #54

huwd opened this issue Feb 7, 2020 · 1 comment

Comments

@huwd
Copy link

@huwd huwd commented Feb 7, 2020

This seems useful.
Wondering how you're approaching time here?

The calculations would always have to be current. I was thinking of spinning off a gem to or api wrapper for HMRC data, to just capture the bandings, thresholds and rates... but i think that would need to be an array of tax years with figures held as values.

What would that do to your cucumber tests?

Could we wrap them in a context:

Given I am trying to assess my tax liabilities for the tax year 2019-2020?

Could then get it to update those whenever we get new bandings?

@Floppy

This comment has been minimized.

Copy link
Member

@Floppy Floppy commented Feb 7, 2020

Yeah, the experiment really didn't get that far. But I think I'd do it with a Given, as you say. Given is the tax year 2019 or somesuch. Do they always change on a tax year basis, or do some things change mid-year? Booze tax, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.