-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible issue with ColorSpace #297
Comments
|
Hi @RussellMcOrmond, I've taken an initial look and there's not a straightforward fix leaps out at me so I won't be addressing this for 1.18 which goes out today. I'm going to assign @tledoux to this as he implemented the colour space code and might be able to give you a fuller answer. |
|
Hi, I implement the colorProfile code for JPEG, not the ColorSpace. In fact, the problem seems to come from the line 1009 in JpegModule where the presence of a JFIF header wrongly implies a YCbCr color space. So this seems like a bug (at least, a shortcut) that needs to be corrected. @RussellMcOrmond, can we add your files to the corpora so that we can build tests for these cases ? |
|
Thanks @tledoux |
|
Yes, @tledoux , you can use those files as test cases. You can download using Cantaloupe from our repository, of I can attach them if that is easier. Turns out we only had two CMYK images in that collection which is the title pages of the English and French versions of the same document. http://parl.canadiana.ca/view/oop.debates_CDC0104_01/1?r=0&s=1 From cantaloupe-project/cantaloupe#177 , to download you:
|
|
Hi @RussellMcOrmond I had a look at this for the 1.20 release but I haven't been able to fix it at a first pass as the research left me a little confused. Reading the APP0 material I've Googled does suggest that the use of a JFIF header implies CMYK. It's also obvious that tools like ImageMagick do more than this but the "rules" aren't straightforward. I agree with @tledoux that the current shortcut should be replace, it's just not currently clear by what. |
Calculate the appropriate colorspace depending on the number of components and the segments Add the "Adobe JPEG" profile and the information on the corresponding ISO/IEC 10918-6:2013 Suppress the warning message about deprecated JPEG compression scheme coming from the TIFF module Add more control on the validity of the format : - 3 components only for EXIF - 1, 3 or 4 components for other profiles Add a YCCK colorspace value to the niso property The JPEG module goes to version 1.5.2 Fixes openpreserve#297
|
I wanted to add our use case. We have an image with an ICC Profile "Display P3" which is throwing an ErrorMessage "Invalid ICCProfile in APP2 segment, No description in ICC profile v4" Offset 596. Jpeg is Well-Formed and valid. |
Dev Effort
2D
Description
We have some CMYK which aren't differentiated in the JHOVE 1.16.5 reports. I'm wondering if this is a problem in the software, or that I'm not using the tool correctly.
Using ImageMagick's identify it notices the differences between a lone CMYK image and Greyscale images.
Jhove indicated YCbCr for all of them.
I noticed this issue when trying to confirm image differences in the context of cantaloupe-project/cantaloupe#177
The text was updated successfully, but these errors were encountered: