Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit handler clean-up and bug fixes #411

Merged
merged 4 commits into from Mar 29, 2019

Conversation

Projects
None yet
2 participants
@david-russo
Copy link
Member

commented Mar 12, 2019

  • Prevented handler from crashing when file information lacks MIME type.
  • Grouped and reported any files which lack MIME types in the MIME type summary.
  • Replaced "not found" and "not processed" status values with "unknown" to align with other reports.
  • Added in-report documentation for how to interpret the summary values.
  • Corrected summary counts of well-formed files (they previously also included malformed files).
  • Expanded summary values to include counts for "not well-formed" and "unknown" files.

NB: This pull request contains code reformatting, so see individual commits for clearer change sets.

david-russo added some commits Mar 11, 2019

AUDIT: Correct and align status reporting with other handlers
Audit reports weren't correctly differentiating between the standard
levels of validity in the report summaries, instead grouping
"well-formed" and "not well-formed" together, as well as ignoring
files of undetermined status.

This change correctly counts all current status types, replacing old
"not found" and "not processed" tallies (which were not being counted
correctly for the former, and at all for the latter) with a more
accurate tally of "unknown" statuses.

The concise report summaries have been altered to accommodate the new
tallies and also include documentation on how to interpret their values.
@codecov

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

Merging #411 into integration will decrease coverage by 2.9%.
The diff coverage is 7.6%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #411      +/-   ##
=================================================
- Coverage          52.71%   49.81%   -2.91%     
+ Complexity          1119      976     -143     
=================================================
  Files                 55       55              
  Lines               9343     7633    -1710     
  Branches            2284     1377     -907     
=================================================
- Hits                4925     3802    -1123     
+ Misses              3890     3372     -518     
+ Partials             528      459      -69
Impacted Files Coverage Δ Complexity Δ
...arvard/hul/ois/jhove/handler/audit/AuditCount.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...arvard/hul/ois/jhove/handler/audit/AuditState.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...du/harvard/hul/ois/jhove/handler/AuditHandler.java 9.21% <9.79%> (ø) 2 <2> (ø) ⬇️
.../java/edu/harvard/hul/ois/jhove/ConfigHandler.java 59.66% <0%> (-9.57%) 27% <0%> (-23%)
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 63.07% <0%> (-8.04%) 274% <0%> (-80%)
...c/main/java/edu/harvard/hul/ois/jhove/Message.java 80% <0%> (-8%) 10% <0%> (-2%)
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 42.79% <0%> (-5.86%) 42% <0%> (-36%)
...edu/harvard/hul/ois/jhove/handler/TextHandler.java 0.54% <0%> (-0.1%) 2% <0%> (-2%)
...rvard/hul/ois/jhove/messages/JhoveMessageImpl.java 83.33% <0%> (+60.6%) 5% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b89503...da9fae7. Read the comment docs.

@david-russo david-russo added the bug label Mar 14, 2019

@carlwilson carlwilson merged commit acf4608 into openpreserve:integration Mar 29, 2019

1 of 4 checks passed

codecov/patch 7.6% of diff hit (target 52.71%)
Details
codecov/project 49.81% (-2.91%) compared to 5b89503
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.