Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - XML Module failure when no checksumming #427

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
1 participant
@carlwilson
Copy link
Member

commented Mar 26, 2019

  • removed unused configuration extensions;
  • made ChecksumInputStream _cstream private to ModuleBase to avoid abuse by other modules;
  • XmlModule now forced to use _dstream so works without checksumming engaged; and
  • added defensive exit to change directories in bash scripts.
FIX - XML Module failure when no checksumming
- removed unused configuration extensions;
- made `ChecksumInputStream _cstream` private to `ModuleBase` to avoid abuse by other modules;
- `XmlModule` now forced to use `_dstream` so works without checksumming engaged; and
- added defensive `exit` to change directories in bash scripts.

@carlwilson carlwilson added bug P1 labels Mar 26, 2019

@carlwilson carlwilson added this to the v1.22-m4 Release milestone Mar 26, 2019

@carlwilson carlwilson self-assigned this Mar 26, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 26, 2019

Codecov Report

Merging #427 into rc/jhove-1.22 will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             rc/jhove-1.22     #427      +/-   ##
===================================================
- Coverage            48.81%   48.67%   -0.14%     
+ Complexity             958      954       -4     
===================================================
  Files                   55       55              
  Lines                 7666     7659       -7     
  Branches              1394     1393       -1     
===================================================
- Hits                  3742     3728      -14     
- Misses                3445     3458      +13     
+ Partials               479      473       -6
Impacted Files Coverage Δ Complexity Δ
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 42.85% <ø> (+0.06%) 42 <0> (ø) ⬇️
...ain/java/edu/harvard/hul/ois/jhove/ModuleBase.java 50.69% <ø> (ø) 70 <0> (ø) ⬇️
.../java/edu/harvard/hul/ois/jhove/ConfigHandler.java 60% <ø> (+0.33%) 26 <0> (-1) ⬇️
...in/java/edu/harvard/hul/ois/jhove/Checksummer.java 67.79% <0%> (-11.87%) 13% <0%> (-2%)
...edu/harvard/hul/ois/jhove/ChecksumInputStream.java 68.42% <0%> (-10.53%) 9% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2bac74...22f1f67. Read the comment docs.

@carlwilson carlwilson merged commit 5e1e64a into rc/jhove-1.22 Mar 27, 2019

4 of 5 checks passed

codecov/project 48.67% (-0.14%) compared to a2bac74
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing a2bac74...22f1f67
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carlwilson carlwilson deleted the fix/xml-parsing branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.