Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - PDF Indirect Object Message #428

Merged
merged 3 commits into from Mar 27, 2019

Conversation

Projects
None yet
1 participant
@carlwilson
Copy link
Member

commented Mar 27, 2019

  • fixed bug in reporting of indirect object message.

Bug caused by Java's interpretation of message patterns, particularly
rules governing single quotes and format items.
See https://docs.oracle.com/javase/7/docs/api/java/text/MessageFormat.html

closes #414

carlwilson added some commits Mar 27, 2019

FIX - PDF Indirect Object Message
- fixed bug in reporting of indirect object message.

Bug caused by Java's interpretation of message patterns, particularly
rules governing single quotes and format items.
See https://docs.oracle.com/javase/7/docs/api/java/text/MessageFormat.html

@carlwilson carlwilson self-assigned this Mar 27, 2019

@carlwilson carlwilson added bug P1 labels Mar 27, 2019

@carlwilson carlwilson added this to the v1.22-m4 Release milestone Mar 27, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 27, 2019

Codecov Report

Merging #428 into rc/jhove-1.22 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             rc/jhove-1.22     #428   +/-   ##
================================================
  Coverage            48.81%   48.81%           
  Complexity             958      958           
================================================
  Files                   55       55           
  Lines                 7666     7666           
  Branches              1394     1394           
================================================
  Hits                  3742     3742           
  Misses                3445     3445           
  Partials               479      479

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2bac74...eae275d. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Mar 27, 2019

Codecov Report

Merging #428 into rc/jhove-1.22 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             rc/jhove-1.22     #428   +/-   ##
================================================
  Coverage            48.67%   48.67%           
  Complexity             954      954           
================================================
  Files                   55       55           
  Lines                 7659     7659           
  Branches              1393     1393           
================================================
  Hits                  3728     3728           
  Misses                3458     3458           
  Partials               473      473

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1e64a...113f61b. Read the comment docs.

@carlwilson carlwilson merged commit d6660b5 into rc/jhove-1.22 Mar 27, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing 5e1e64a...113f61b
Details
codecov/project 48.67% remains the same compared to 5e1e64a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carlwilson carlwilson deleted the fix/pdf-indirect-message branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.