Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate valid mix10 and mix20 metadata (various values are Rational). #429

Merged
merged 4 commits into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@carlwilson
Copy link
Member

commented Mar 27, 2019

The Brightness, ApertureBias and FlashEnergy properties are now Rational as needed for the versions 1.0 and 2.0 of the MIX schema.
Add unit test for all the new outputs.
Should also correct #387 : need for a sample file.

tledoux and others added some commits Feb 28, 2019

Merge pull request #394 from tledoux/erroneousMix
Generate valid mix10 and mix20 metadata (various values are Rational).
@codecov

This comment has been minimized.

Copy link

commented Mar 27, 2019

Codecov Report

Merging #429 into rc/jhove-1.22 will increase coverage by 4.03%.
The diff coverage is 70.96%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             rc/jhove-1.22     #429      +/-   ##
===================================================
+ Coverage            48.67%   52.71%   +4.03%     
- Complexity             954     1119     +165     
===================================================
  Files                   55       55              
  Lines                 7659     9343    +1684     
  Branches              1393     2284     +891     
===================================================
+ Hits                  3728     4925    +1197     
- Misses                3458     3890     +432     
- Partials               473      528      +55
Impacted Files Coverage Δ Complexity Δ
...edu/harvard/hul/ois/jhove/handler/TextHandler.java 0.64% <0%> (+0.09%) 4 <0> (+2) ⬆️
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 71.11% <100%> (+10.11%) 354 <0> (+98) ⬆️
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 74.64% <100%> (+0.86%) 175 <0> (+2) ⬆️
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 48.65% <0%> (+5.79%) 78% <0%> (+36%) ⬆️
.../java/edu/harvard/hul/ois/jhove/ConfigHandler.java 69.23% <0%> (+9.23%) 50% <0%> (+24%) ⬆️
...edu/harvard/hul/ois/jhove/ChecksumInputStream.java 78.94% <0%> (+10.52%) 10% <0%> (+1%) ⬆️
...in/java/edu/harvard/hul/ois/jhove/Checksummer.java 79.66% <0%> (+11.86%) 15% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6660b5...5b89503. Read the comment docs.

@carlwilson carlwilson merged commit 51ff8a8 into rc/jhove-1.22 Mar 27, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 70.96% of diff hit (target 48.67%)
Details
codecov/project 52.71% (+4.03%) compared to d6660b5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.