add default switch statements #507
Conversation
Codecov Report
@@ Coverage Diff @@
## integration #507 +/- ##
=================================================
- Coverage 49.7% 49.69% -0.02%
Complexity 987 987
=================================================
Files 55 55
Lines 7748 7750 +2
Branches 1406 1371 -35
=================================================
Hits 3851 3851
- Misses 3433 3435 +2
Partials 464 464
Continue to review full report at Codecov.
|
carlwilson
added
feature
There was a problem hiding this comment.
I mostly wholeheartedly approve of these changes, there's one or two I halfheartedly approve of but recent PRs from others lead me to suspect I'm in a minority. Checking the appropriate style guidelines didn't strengthen my points ;).
Just the one comment inline, I suspect the problem is my understanding.
Finally I'll hold off this PR until a few earlier ones are merged. Many of the changes here are logical and I'd rather deal with conflicts in this branch / PR than others.
| @@ -446,11 +450,7 @@ public int parse(InputStream stream, RepInfo info, int parseIndex) { | |||
| HtmlDocDesc docDesc = null; | |||
| switch (type) { | |||
| case HTML_3_2: | |||
| default: | |||
There was a problem hiding this comment.
@nvanderperren I'm missing something with this deletion? A quick explanation for the hard of understanding please.
There was a problem hiding this comment.
the null values are not necessary because it's not used nor checked. Only the values that are assigned in the if or switch statements are used. But I was maybe a bit too eager.
|
Thanks @carlwilson . Next time, I'll create a new branch for the lacking Javadoc documentation and a seperate PR for that issue. |
tries to solve #422
since it wasn't much, I also added
@param,@return,@throwsetc. to the Javadocs.