Skip to content

fix(cli): pass granular Codex runtime options#78

Merged
rawwerks merged 1 commit into
mainfrom
codex/codex-granular-options-main-20260513
May 13, 2026
Merged

fix(cli): pass granular Codex runtime options#78
rawwerks merged 1 commit into
mainfrom
codex/codex-granular-options-main-20260513

Conversation

@rawwerks
Copy link
Copy Markdown
Contributor

Summary

  • forward PROSE_CODEX_ADD_DIR into Codex SDK additionalDirectories
  • forward strict PROSE_CODEX_NETWORK=true|false into networkAccessEnabled
  • document the new Codex harness env vars
  • refresh vulnerable transitive production lockfile entries so CLI release audit stays green

This PR targets main directly and contains only the Codex runtime-options fix. The earlier PR #77 landed the same fix into feat/cli-prose-chain; this PR is the main-targeted cherry-pick.

Verification

  • npm ci
  • npm run typecheck
  • TMPDIR=/var/tmp/prose-codex-tests npm test -- tests/harnesses/harnesses.test.ts
  • npm audit --omit=dev
  • git diff --check origin/main..HEAD

Golden-finch also confirmed the patch end-to-end with workspace-write, PROSE_CODEX_ADD_DIR, and PROSE_CODEX_NETWORK=true against a live grant-radar run.

Forward PROSE_CODEX_ADD_DIR and PROSE_CODEX_NETWORK into Codex SDK thread options so workspace-write runs can grant narrow extra filesystem and network capabilities without danger-full-access.

Also refresh vulnerable transitive production dependencies in the CLI lockfile so the release audit remains green.
Copy link
Copy Markdown
Contributor Author

Reviewed against the contribution bar from #75.

No blocking issues found.

Standards check:

  • Use case / evidence: clear. The PR names the runtime-options gap, explains this is the main-targeted cherry-pick of fix(cli): pass granular Codex runtime options #77, and includes live run evidence from the grant-radar flow.
  • One responsibility: acceptable. The functional change is narrowly scoped to Codex SDK runtime options; the lockfile refresh is supporting work for the stated CLI release audit.
  • Layer boundary: correct. This belongs in tools/cli harness code and README docs, not in OpenProse language/spec semantics.
  • Retestable checks: good. The test covers merged additionalDirectories, strict PROSE_CODEX_NETWORK=true, sandbox mode, approval policy, and invalid network values.

I verified locally on the PR worktree:

  • npm run typecheck
  • TMPDIR=/var/tmp/prose-codex-tests npm test -- tests/harnesses/harnesses.test.ts
  • npm audit --omit=dev
  • git diff --check origin/main..HEAD

All passed. GitHub Actions for the head commit are also green: OpenProse Smoke, CLI Real Harness Smoke, and CLI Release Check.

Residual non-blocking gap: there is no explicit PROSE_CODEX_NETWORK=false assertion, but the implementation handles false correctly by checking networkAccessEnabled === undefined rather than truthiness. Not worth blocking.

Note: I attempted to submit this as an approving review, but GitHub rejected it because the authenticated account cannot approve its own PR, so I’m leaving it as a standards-based review comment instead.

@rawwerks rawwerks merged commit a6f8546 into main May 13, 2026
23 checks passed
rawwerks added a commit to openprose/grant-finder that referenced this pull request May 13, 2026
Replaces the "TBD" placeholder in grant-radar.prose.md Prerequisites with
a real link to openprose/prose#78 ("fix(cli): pass granular Codex runtime
options"). Once that PR ships in a tagged prose release, users on the
granular invocation get a concrete version to install. Until then the
danger-full-access fallback documented alongside continues to work on any
prose version.

Also picks up the README.md "Current maturity" framing update.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant