-
Notifications
You must be signed in to change notification settings - Fork 4
For the download from the OR menu: Added .git to the url in 3 places. Added some sizes. #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That's right; GitHub simply redirects all URLs ending in
I can't speak for the ORMT, but I don't see how adding it could upset anyone. Meanwhile I will approve Thank you for your contributions. |
|
hi Looky1173, |
…s/content.git. This will only work once PR openrails/content#8 is reviewed and merged
cjakeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Siebren,
Thanks for this update.
Approved and merged
Don't think permission is needed, but it would be polite to ask first, so they know what we're doing.
I think the plan is to set the permissions on this repo to be the same as the main repo and applied in the same way - by peer review. I'll check with James whether this can be done easily. |
|
I've asked Alderion via Elvastower about his Portugese route to be added.
It's also better if he gives a description for the route.
Op di 26 dec 2023 om 15:08 schreef Chris Jakeman ***@***.***>:
… I'm missing the Portuguese route OR CPV. Can I add that one or do you ask
the owners for permission?
Don't think permission is needed, but it would be polite to ask first, so
they know what we're doing.
(Ah, it turns out I don't have the permissions to do that!)_, and feel
free to add the Portuguese route in a new one.
I think the plan is to set the permissions on this repo to be the same as
the main repo and applied in the same way - by peer review.
I'll check with James whether this can be done easily.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4HHNDNKV5BQ7AM72IOIFJLYLLK5FAVCNFSM6AAAAABBBRFVNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGU3TAMZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I don't think that adding the .git interferes with the website which is using this URL. With the URL ending in .zip and .git I can distinguish between the different download methods. The route URLs without these I just skip.
I see also routes with an executable as the means to install the route. That looks to be not usable. As a User Interface would pop up after starting the .exe. Besides the risk of viruses.
I'm missing the Portuguese route OR CPV. Can I add that one or do you ask the owners for permission?