Skip to content

Conversation

@sweiland-openrails
Copy link
Contributor

@sweiland-openrails sweiland-openrails commented Dec 24, 2023

I don't think that adding the .git interferes with the website which is using this URL. With the URL ending in .zip and .git I can distinguish between the different download methods. The route URLs without these I just skip.

I see also routes with an executable as the means to install the route. That looks to be not usable. As a User Interface would pop up after starting the .exe. Besides the risk of viruses.

I'm missing the Portuguese route OR CPV. Can I add that one or do you ask the owners for permission?

@Looky1173
Copy link

Looky1173 commented Dec 24, 2023

I don't think that adding the .git interferes with the website which is using this URL.

That's right; GitHub simply redirects all URLs ending in .git to their respective "normal" repository URLs.

I'm missing the Portuguese route OR CPV. Can I add that one or do you ask the owners for permission?

I can't speak for the ORMT, but I don't see how adding it could upset anyone. Meanwhile I will approve and merge this PR (Ah, it turns out I don't have the permissions to do that!), and feel free to add the Portuguese route in a new one.

Thank you for your contributions.

@sweiland-openrails
Copy link
Contributor Author

hi Looky1173,
I asked you for a review. Did not do that before. Might help, lets try again. Otherwise we have to ask Chris.
regards, Siebren.

sweiland-openrails added a commit to sweiland-openrails/openrails that referenced this pull request Dec 25, 2023
@Looky1173
Copy link

Hi,

It looks like it still didn't work. But that's to be expected, as I don't have write access to this repository. Your PR must be approved by @cjakeman or @twpol.

Copy link
Contributor

@cjakeman cjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siebren,

Thanks for this update.

Approved and merged

@cjakeman
Copy link
Contributor

I'm missing the Portuguese route OR CPV. Can I add that one or do you ask the owners for permission?

Don't think permission is needed, but it would be polite to ask first, so they know what we're doing.

(Ah, it turns out I don't have the permissions to do that!)_, and feel free to add the Portuguese route in a new one.

I think the plan is to set the permissions on this repo to be the same as the main repo and applied in the same way - by peer review.

I'll check with James whether this can be done easily.

@cjakeman cjakeman merged commit 717811b into openrails:main Dec 26, 2023
@sweiland-openrails
Copy link
Contributor Author

sweiland-openrails commented Dec 26, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants